Repository navigation
Feature/sc 47818/la entrypoint in null search results page - #3820
Draft
stevekaplan123 wants to merge 26 commits into
Draft
stevekaplan123 wants to merge 26 commits into
stevekaplan123 wants to merge 26 commits into
Conversation
…-on' into feature/sc-47701/la-on-mobile-web
…-on' into feature/sc-47701/la-on-mobile-web
div.header is 0px tall because the bar inside it (.headerInner) is fixed to the top of the window, and Playwright treats a 0px element as hidden. Check .headerInner instead, so the test can reach its real assertion that no Library Assistant pill appears on Voices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test-first Playwright coverage of the "Search with no results" stories (LA-NULL-1 to LA-NULL-15): desktop spec in e2e-tests/assistant/, phone rows of LA-NULL-1 and LA-NULL-5 in e2e-tests/mobile web/. Logged-out stories are test.fixme placeholders until the logged-out assistant exists. Helpers: chat server mock records the chat each question went to and can list chats asked during a test; search page object can run searches and read the null state; Q4 page object handles the "Search with Library Assistant" launcher; new nullStateRecorder for LA-NULL-3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is crowded At 900–960px and 1087–1159px the pill says "Ask" / "שאלו"; below 900px it's hidden. Widths come from the most crowded header (logged out), so the pill never comes within 16px of "Donate" or pushes the header icons off screen, in English or Hebrew. The short label is inline until its strings are in Weblate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Weblate key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…page With the assistant on, the body uses the Library Assistant copy, and its "Library Assistant" (עוזר הספרייה) is a purple underlined link that sends the same question as the "Search with Library Assistant" button. The sentence breaks after its last "or" (או), and 104px of bottom padding keeps the text clear of the floating button. The "Something seems wrong?" line is removed, along with its styles and the SRCH-064 test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…8/la-entrypoint-in-null-search-results-page
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A brief description of the PR
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here