Repository navigation
fix: full-size photo stayed a thumbnail on every other fullscreen open - #76
Merged
Merged
Conversation
Assisted-by: claude-opus-5-5 Claude-Session: https://claude.ai/code/session_01AGV9BpZqVbQo1GevPnMD6T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fullscreen viewer that App.jsx keeps for the whole session cleared its fetched full-size photos on open, but its fetch effect runs in the same commit and still saw the previous opening's photo at slide 0, so it skipped the download; the map was then cleared and the 256 px thumbnail stayed. Result: every other photo opened from a list never reached full size (in the app since the thumb/full split, 9c615f2). The viewer now keeps fetched photos by image id instead of slide index and drops them on close; keying by id also stops a slide from showing the deleted photo after a delete in the edit modals. Verified: lint clean on the file,
npm run buildpasses; in a browser (the Drive edition build, which shares this component unchanged apart from its import) the old viewer gave full / thumb / full / thumb / full for five photos in a row, the fixed one gave full size for eight in a row, and reopening a photo used the cache. Still to check on a device: open several different photos fullscreen one after another in the real app; each should sharpen to full size.Assisted-by: claude-opus-5-5
https://claude.ai/code/session_01AGV9BpZqVbQo1GevPnMD6T