CI: strip broken repo.pdi.dev apt source from CI container before apt-get update - #322
Conversation
Remove references to 'pdi.dev' from sources list before installing gfortran.
Remove command to delete pdi.dev sources from apt.
Remove pdi.dev sources from apt sources list before updating.
Remove outdated PDI source list entries before updating packages.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 79 79
Lines 8643 8643
=======================================
Hits 8427 8427
Misses 216 216 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mknaranja
left a comment
There was a problem hiding this comment.
Looks good. I'd merge this here or do you see the change on the gysela side shortly upcoming @EmilyBourne ?
|
@tpadioleau can you have a look at this? |
|
It seems to work so let's go. I would advise you to consider having your own docker image. If on the Gyselalib++ side we do an update that breaks your CI that would be a little weird to me. |
|
@tpadioleau You are right. Yet, on the short to mid term range, everything we target is the itegration into Gysela -- as intended when I started to work with EoCoE ;-) I told Emily that you could make adaptations in that direction directly in the repo. So, for the moment, I think it is fine. If there anyway is a change on the Gysela side as Julian suggested, we could also do some minor adaptation here. |
The CI is failing since 2 weeks.
E: The repository 'https://repo.pdi.dev/ubuntu noble Release' does not have a Release file.
Claude analysis:
Root cause
We don't reference
repo.pdi.devanywhere in our own workflow/action files.The source comes from the
ghcr.io/gyselax/gyselalibxx_env:latestcontainerimage we pull for every job — it ships a preconfigured apt source pointing at
repo.pdi.dev/ubuntu, which no longer serves a validReleasefile fornoble(PDI's current documented path isrepo.pdi.dev/pdi-main.ubuntu).Since we pin that image to
:latest, an upstream rebuild ofgyselalibxx_envsilently broke our CI with zero commits on our side.Fix
Strip any apt source referencing
pdi.devbefore runningapt-get update,in every composite action that does an update:
.github/actions/build/action.yml.github/actions/cuda_build/action.yml.github/actions/test/action.yml.github/workflows/main.yml(clang-format job)The guard is a no-op if no matching source file exists, so it's safe to keep
long-term as defensive hardening against the same class of upstream breakage.
Follow-up (not in this PR)
gyselalibxx_envto a digest instead of:latestso anupstream image change can't silently break CI again.
gyselax/gyselalibxx_env— their PDI aptsource appears broken for anyone using that image, not just us.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):