Skip to content

Mark the current nav item active by path instead of substring #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukefretwell merged 1 commit into from
Oct 23, 2026
Merged

Mark the current nav item active by path instead of substring #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion _includes/nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@
<ul class="navbar-nav mb-2 mb-lg-0">
{% for item in nav %}
{% if item.url %}
{# Current page, or anything under the item's URL; "/" matches only the home page #}
{% set isActive = page.url == item.url or (item.url != '/' and page.url.indexOf(item.url) == 0 and (item.url.slice(-1) == '/' or page.url.charAt(item.url.length) == '/')) %}
<li class="nav-item me-3 me-lg-0 small">
<a class="nav-link mx-1{% if item.url in page.url %} active{% endif %}" {% if item.url in page.url %}aria-current="page"{% endif %} href="{{ item.url }}">
<a class="nav-link mx-1{% if isActive %} active{% endif %}" {% if isActive %}aria-current="page"{% endif %} href="{{ item.url }}">
<i class="{{ item.icon }} me-2"></i>
{{ item.title }}
</a>
Expand Down
Loading