Repository navigation
City: realistic models only, no low-poly kit - #34
Merged
Merged
Conversation
Delete the low-poly kit (city-kit.glb, city_kit.py, kit.ts), the window atlas it used (textures.ts; the particle sprite moves to fx.ts), and every fallback to it: kit buildings and yards, kit trees, cars, people, crane, scaffold, rubble, bridge, street lamps, fences and the flat-colour stand-ins for lawns and streets. - The app creates the city only once the model pack is whole; until then the HUD shows the download. It starts the city in place, no reload. - loadReal loads every model or throws, so a missing model or a GPU without BC7 shows "Skyline unavailable" instead of a half-drawn city. The viewers (proto, town) still skip missing ones. - STYLES drops the kit-only round office and glass, twist and TV towers; a test checks every look the plan can produce has a model. - The crane's anchors move into models.ts (CRANE). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #33. GitHub retargets it to
mainonce #33 merges.Deletes the low-poly kit and every fallback to it. The city now draws only the realistic models.
city-kit.glb,blender/city_kit.py,kit.ts, and the kit window atlas (textures.ts; the particle sprite moved tofx.ts). Also removed: the kit building stacker and yards, and the kit trees, cars, people, crane, scaffold, rubble, bridge and lamps. The flat-colour stand-ins for lawns, streets and fences went too.loadRealloads every model or throws. A missing model, or a GPU without BC7, showsSkyline unavailable: …and the HUD keeps working. The viewer pages (proto.html,town.html) still skip missing models.CRANEinmodels.ts.341 lines added, 938 removed.
Checks:
tsc,bun test(38 pass, including the new test, which fails if a model-less style is put back),vite build,cargo check -p deepwork-ui. Screenshots in headless Chromium of the hamlet, city with a construction site, ruins, metropolis, and the city at night. Renamings3.glbshowedSkyline unavailable: Error: models missing: s3.🤖 Generated with Claude Code