Repository navigation
City: retune daylight; leaf depth pre-pass and backlight - #32
Merged
Merged
Conversation
The day's fill was a flat white ambient brighter than the sun, tuned for the low-poly kit. It lit every face alike, so the realistic buildings looked flat and their shadows faint, and late afternoon looked overcast. - Most of the day fill moves to the hemisphere light (cool sky above, warm ground bounce below); the ambient keeps its night share (DAY_FILL). - Warmer, stronger sun; orange sun and lilac shade at golden hour, with a little more exposure then. - Nearer haze, so the city stands off from the woods behind it. Same lights, same cost. Mean brightness (bench-app LUMA, city): 13h 107.7 -> 108.1, 17:30 79.6 -> 68.9 (warmer, deliberately), 22h 23.0 -> 22.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A crown is many layers of alpha-tested cards, and with a cut-out the GPU lights every layer before the depth test drops the hidden ones. The leaves now draw a cut-out-only depth pass first, then the lit pass with no depth writes, so each pixel is lit once. The pre-pass repeats the woods' near-only vertex step (userData.vertex), or far crowns showed the sky through (blooming white blobs), and sits a hair behind (polygon offset). Leaves also let light through: a crown glows against a low sun. GPU (bench-app, headless): Hamlet fixed view 19.6 -> 18.3 ms, Hamlet opening view 20.8 -> 19.5; metropolis unchanged (~30), its trees being mostly impostors. &leaves=0 turns both off for comparison. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sagyam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daylight for the realistic models: hemisphere sky fill instead of a flat ambient by day, warmer sun with a real golden hour, nearer haze. Night unchanged.
Leaves: a cut-out-only depth pre-pass, so each pixel of a crown is lit once (Hamlet ~1.3 ms of ~20 GPU; metropolis unchanged), and backlight through the leaves.
&leaves=0turns both off.Docs: APP.md performance and decisions, DEVELOPMENT.md flag, roadmap tree item narrowed to the far woods.
Judged from headless screenshots and timings; needs a look and an fps check in the real window.
🤖 Generated with Claude Code