Repository navigation
fix: long number IDs are variables; Start here skips patterns with no lines - #57
Merged
Merged
Conversation
… lines Numbers of 15 or more digits, quoted or not, and lists of them separated by commas or spaces are masked to one <*> before mining, like UUIDs. The discovery run format goes to 4, so older imports must be imported again. Start here no longer lists a pattern that has no lines in this import. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Unquoted long numbers next to each other, on one line or across lines, stay separate fields; a comma list or double-quoted numbers separated by spaces (an execution plan's array) are still one <*>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Quoting does not make two IDs a list. Long numbers separated by spaces are masked as one <*> only inside an array literal's braces, which are kept; everywhere else each is its own field. Comma lists are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems EiuCC found in the real VictoriaLogs run (postgres_logs through the Grafana proxy):
7495738030435460753), optionally quoted, and a list of them separated by commas or spaces ("749…753" "749…111"in an execution plan) are now masked to a single<*>before mining, alongside the existing date-time and UUID masks. Field values still show the real text. Shorter numbers (ports, 13-digit epoch ms) are untouched.startHerenow skips any pattern with no lines in this import.Templates change, so
DiscoveryRunFormatgoes from 3 to 4: imports made before this need to be imported again (the existing "older version" flow handles it).Checked with
go vetandgo test ./.... I also ranMaskInlineon sample lines: the plan's quoted ID list, a comma-separated list, a 15-digit number (masked), a 14-digit number (kept), and a UUID followed by an ID. Acceptance: EiuCC reruns the same VictoriaLogs data and checks that no long numbers remain in names and that Start here has no 0-line rows.🤖 Generated with Claude Code