Skip to content

[Update] Upgrade dependencies to NUnit 5 and uml4net 9.2 - #419

Merged
samatstariongroup merged 2 commits into
developmentfrom
update-deps
Nov 6, 2026
Merged

samatstariongroup merged 2 commits into
developmentfrom
update-deps

Conversation

@samatstariongroup

Copy link
Copy Markdown
Member

Updates the centrally managed NuGet versions and fixes the resulting build and test breaks.

Changes

  • NUnit 5.0.0: Assert.ThrowsAsync now returns a Task; StreamExtensionsTestFixture uses await Assert.ThatAsync(..., Throws.ArgumentNullException...) instead.
  • Moq: pinned to 4.21.0, the latest published version (5.0.0 does not exist on nuget.org).
  • uml4net 9.2.0: now ships QueryAllNonDerivedNonRedefinedProperties and QueryIsEnumPropertyWithDefaultValue, which made calls ambiguous with the code generator's own versions. The local versions are kept (ours orders properties by name, which generated output relies on) and called explicitly in ClassHelper, PropertyHelper and their test fixtures.
  • Other test, library and code-generator package bumps in Directory.Packages.props.

Testing

  • Solution builds with 0 errors.
  • dotnet test --filter "TestCategory!=Integration&TestCategory!=Benchmark": all pass except Verify_that_expected_sql_schema_is_generated, which fails on Windows only because of CRLF/LF line endings and fails the same way before this change (CI on Linux is unaffected).

Known

  • NUnit 5 marks [Order] obsolete: 16 warnings in SqlSchemaBenchmarkTestFixture, left as-is because those benchmark steps depend on running in sequence.

🤖 Generated with Claude Code

@antoineatstariongroup antoineatstariongroup left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it bring changes on the way to call extension methods?

@samatstariongroup

Copy link
Copy Markdown
Member Author
  • uml4net 9.2.0: now ships QueryAllNonDerivedNonRedefinedProperties and QueryIsEnumPropertyWithDefaultValue, which made calls ambiguous with the code generator's own versions. The local versions are kept (ours orders properties by name, which generated output relies on) and called explicitly in ClassHelper, PropertyHelper and their test fixtures.

see original description of PR:
uml4net 9.2.0: now ships QueryAllNonDerivedNonRedefinedProperties and QueryIsEnumPropertyWithDefaultValue, which made calls ambiguous with the code generator's own versions. The local versions are kept (ours orders properties by name, which generated output relies on) and called explicitly in ClassHelper, PropertyHelper and their test fixtures.

@antoineatstariongroup

Copy link
Copy Markdown
Collaborator
  • uml4net 9.2.0: now ships QueryAllNonDerivedNonRedefinedProperties and QueryIsEnumPropertyWithDefaultValue, which made calls ambiguous with the code generator's own versions. The local versions are kept (ours orders properties by name, which generated output relies on) and called explicitly in ClassHelper, PropertyHelper and their test fixtures.

see original description of PR: uml4net 9.2.0: now ships QueryAllNonDerivedNonRedefinedProperties and QueryIsEnumPropertyWithDefaultValue, which made calls ambiguous with the code generator's own versions. The local versions are kept (ours orders properties by name, which generated output relies on) and called explicitly in ClassHelper, PropertyHelper and their test fixtures.

I propose that we then remove local implementation in favor of uml4net once

…ring only for the MessagePack template helper
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@samatstariongroup
samatstariongroup merged commit 99fba6e into development Nov 6, 2026
8 checks passed
@samatstariongroup
samatstariongroup deleted the update-deps branch November 6, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants