Skip to content

feat(serverless): align the CLI with the 0.6.0 control plane - #122

Closed
Ryank90 wants to merge 2 commits into
rc/serverlessfrom
feat/serverless-cli-mvp-fixes
Closed

Ryank90 wants to merge 2 commits into
rc/serverlessfrom
feat/serverless-cli-mvp-fixes

Conversation

@Ryank90

@Ryank90 Ryank90 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Stacked on feat(serverless): sync OpenAPI 0.6.0 and treat 402 as quota #121. Depends on the regenerated 0.6.0 client (effectiveMaxWorkers, log sort/cursors, 402 types).
  • Must-fix: env/secrets help, apps workers --version all|<id>, pack total 10 MiB, hide activity/errorRate sorts, local gpus-per-worker 1|2|4|8.
  • Display: apps show runtime + effectiveMaxWorkers, endpoint runtime, task endpointPath, logs --sort and prev/next cursors.
  • MVP: README/root mention serverless, --wait/--timeout on activate + resume (+ timeout on deploy/invoke), apps errors, apps rename, create-time scale knobs and --secret, volumes documented as immutable.

Test plan

  • make test
  • make lint
  • make docs
  • runware serverless apps list --sort activity is refused locally
  • runware serverless apps workers <id> lists the active version only; --version all lists every worker
  • runware serverless apps show <id> prints workers, queue, 24h requests, and effective max workers
  • runware serverless apps errors <id> pages request errors
  • runware serverless apps rename <id> "New name" updates the display name
  • runware serverless apps resume <id> --wait --timeout 2m and versions activate … --wait stop polling on timeout
  • Deploy with --gpus-per-worker 3 is refused; --secret NAME attaches on create

The control plane now returns paymentRequired with a shortfall, exposes
effectiveMaxWorkers and log sort/cursors, and accepts 1|2|4|8 GPUs.
Regenerate the client and map 402 so create, scale, activate, and resume
print the credit gap instead of a server error.
Env set, secret attach/detach, and secret set now roll live workers; pack
must stay under the 10 MiB upload cap; workers default to the active
version; and 1|2|4|8 GPUs are validated locally. Show runtime and
effectiveMaxWorkers, pass log sort/cursors through, and add wait/timeout,
apps errors, rename, create-time scale knobs, and --secret on deploy.
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2a0acbf1-3f81-4b70-995b-94b7181e9d69

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Ryank90
Ryank90 marked this pull request as draft September 21, 2026 17:26
Base automatically changed from feat/serverless-openapi-sync to rc/serverless September 22, 2026 10:57
@Ryank90 Ryank90 closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant