Repository navigation
Feat/108 request object signing algs - #120
Merged
Merged
Conversation
patchandthat
requested review from
JoStevensRSK,
jhbritton-RSK and
joe-harvey-rsk
October 16, 2026 11:15
joe-harvey-rsk
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #108. Emits the
request_object_signing_alg_values_supportedproperty in the discovery document, and validates jwt request signatures with respect to the list. Defaults to RS256, RS384, RS512, PS256, PS384, PS512, ES256, ES384 and ES512.Type of change
Does this PR introduce a breaking change?
Does the change cause a breaking change to any of the following?
Breaking behaviour for request objects signed with HSXXX symmetric keys, which really shouldn't be used anyway.
Previous behaviour can be restored by clearing the
SupportedJwtRequestSigningAlgorithmscollection, or adding the additional algorithms on startup.Testing
New tests added.
LLM Usage
Please describe where and how you have used LLM tooling in relation to these changes.
Note: We want all code changes in the shippable nuget packages to be human authored. LLM usage elsewhere is acceptable, you are expected to thoroughly scrutinise any generated content.
Used in generating tests.
Other context
Please include any other contextual information to support this change, if necessary.
eg. Instructions for testing and validating the code, any necessary dependencies or environmental setup