Skip to content

Add weekly note page SmartBlocks command - #536

Merged
mdroidian merged 5 commits into
mainfrom
codex/weekly-note-page-smartblocks
Oct 12, 2026
Merged

mdroidian merged 5 commits into
mainfrom
codex/weekly-note-page-smartblocks

Conversation

@mdroidian

@mdroidian mdroidian commented Aug 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add <%WEEKLYNOTEPAGE:In one week%> to resolve a SmartBlocks date expression into the containing weekly page using the format configured in roam/js/weekly-notes. The command is available in any SmartBlocks workflow while Weekly Notes is enabled.

  • Delegate date resolution to SmartBlocks' actual DATE command, preserving its active DATEBASIS instead of copying its date-basis logic.
  • Resolve This week through DATE:today so a Monday-based week does not accidentally select the previous week.
  • Create or initialize missing and content-empty weekly pages using the weekly template; preserve existing content.
  • Defer and serialize initialization until the outer workflow completes. Weekly links inside templates remain link-only to prevent recursive expansion.
  • Keep navigation independent of template completion and avoid duplicate daily auto-tags.
  • Add 22 committed regression tests for the requested expressions, custom boundaries, Sunday/Monday transitions, year boundaries, delegation, and invalid resolver output.

Validation

Current head: 22f36f8debc81423dfc60056277fb139096c4f4c.

  • npm test: 22 tests passed. Expression cases exercise the installed NLP parser; command-context and graph-writing behavior still require the live check below.
  • npm --ignore-scripts run build:roam: built with 0 errors.
  • git diff --check: passed.
  • tsc --noEmit: 101 errors, identical to the unchanged 2f27785 baseline with the same dependencies. No diagnostics in changed source files.
  • Clean npm ci --ignore-scripts failed on the existing lockfile's @esbuild/android-arm platform entry. Tests and build used the existing WorkBench dependency installation; clean-install validation remains open.
  • A live Roam developer-load probe succeeded. The subsequent workflow-verification session was blocked by an expired/logged-out Roam profile, so this head does not have completed live workflow verification.

Earlier live testing at aeb15507363534e2383b775b641d7295d75cef14 covered initialization, content preservation, weekly DATEBASIS, and recursion safety. That historical result does not verify the current head. Before merge, rerun the current build with explicit and DNP DATEBASIS, initialization, content preservation, recursion safety, and extension reloads.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b5d9c1fb-2bba-4d61-bc26-3e6f9022194b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread src/utils/weeklyNotePage.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aeb1550736

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/features/weekly-notes.ts
@mdroidian

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19208ba87c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/features/weekly-notes.ts Outdated
@mdroidian

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 2f27785796

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mdroidian

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 2f27785796

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T17:59:36.341190Z 22f36f8 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mdroidian
mdroidian merged commit 37b86e9 into main Oct 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant