Skip to content

Extend GPUArrays compat to 12 #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lkdvos wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend GPUArrays compat to 12 #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b559ca3
Extend GPUArrays compat to 12 and JLArrays compat to 0.4
lkdvos Oct 9, 2026
8cf09bc
Only mark the warm-buffer JLArray contraction as broken before JLArra…
lkdvos Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ ChainRulesTestUtils = "1"
DynamicPolynomials = "0.5, 0.6"
Enzyme = "0.13.183"
EnzymeTestUtils = "0.2"
GPUArrays = "11"
JLArrays = "0.3"
GPUArrays = "11, 12"
JLArrays = "0.3, 0.4"
LRUCache = "1"
LinearAlgebra = "1.6"
Logging = "1.6"
Expand Down
2 changes: 2 additions & 0 deletions docs/src/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Compat with GPUArrays is extended to include 12, and with JLArrays to include 0.4.

### Deprecated

### Removed
Expand Down
10 changes: 6 additions & 4 deletions test/allocator.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,17 +361,19 @@ end
@test buffer.offset == 0
@test buffer.max_offset > 0

# Disjoint JLArray slices are reported as aliases once the buffer is warm.
# Disjoint JLArray slices are reported as aliases once the buffer is warm, unless
# JLArrays implements `GPUArrays.memory_location` (JLArrays v0.4.2, GPUArrays v12.1).
# https://github.com/JuliaGPU/GPUArrays.jl/pull/803
# https://github.com/QuantumKitHub/StridedViews.jl/pull/57
@test_broken begin
aliasing_fixed = pkgversion(JLArrays) ≥ v"0.4.2"
@test begin
@tensor allocator = buffer begin
HRAA3[a, s1, s2, c] := ρₗ[a, a'] * A1[a', t1, b] * A2[b, t2, c'] *
ρᵣ[c', c] * H[s1, s2, t1, t2]
end
collect(HRAA3) ≈ collect(HRAA1)
end
continue # Later checks require the warm-buffer contraction to succeed.
end broken = !aliasing_fixed
aliasing_fixed || continue # Later checks require the warm-buffer contraction to succeed.

# the first contraction already recorded the full requirement, so it no longer grows
max0 = buffer.max_offset
Expand Down
5 changes: 3 additions & 2 deletions test/gpu.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,9 @@ end
@test buffer.offset == 0
@test buffer.max_offset > 0

if AT === JLArray
# Disjoint JLArray slices are reported as aliases once the buffer is warm.
if AT === JLArray && pkgversion(JLArrays) < v"0.4.2"
# Disjoint JLArray slices are reported as aliases once the buffer is warm, unless
# JLArrays implements `GPUArrays.memory_location` (JLArrays v0.4.2, GPUArrays v12.1).
# https://github.com/JuliaGPU/GPUArrays.jl/pull/803
# https://github.com/QuantumKitHub/StridedViews.jl/pull/57
@test_broken begin
Expand Down
Loading