Repository navigation
Conversation
…closed PRs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The exclusions of the Enzyme (macOS, Windows), Mooncake and ChainRules (macOS) tests were only applied when no test group was selected, so they never applied in the TestGroups workflow, where these tests pass on both systems. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared TestGroups workflow now only tests macOS and Windows with Julia 1, on pushes to the default branch. Since Enzyme plays a large role here, this package opts back in for PRs:
extra-os-on-prs: trueruns the macOS and Windows jobs (Julia 1 only) on PRs as well.stagedonly starts them once all ubuntu jobs have passed, so broken or superseded commits do not occupy the scarce macOS runners.Also trigger on
closedPR events: the resulting run cancels any in-progress run of the PR through the concurrency group, and the shared workflow skips all its jobs for it. GitHub does not cancel runs of closed or merged PRs by itself.Test exclusions removed:
test/runtests.jlexcluded the Enzyme tests on macOS and Windows CI, and the Mooncake and ChainRules tests on macOS CI. These exclusions sat behindif filter_tests!(...), which returnsfalsewhenever a test group is passed, so they never applied in the TestGroups workflow. On this PR, all of these jobs pass on both systems (macOS Enzyme takes about 45 min), so the exclusions are removed and the macOS/Windows PR jobs now actually test the AD rules.See QuantumKitHub/QuantumKitHubActions#6 for the shared workflow changes.
🤖 Generated with Claude Code