Expose consumed secret version for read-only snapshot provenance - #638
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset snapshots need to identify the token version actually consumed, so a later rotation cannot silently join observations from different sources. Add optional
GcpSecretStore.get_secret_with_metadata()returning the value and concrete version from one SDK response; unavailable or invalid version metadata staysNone.The value is excluded from repr. Existing secret interfaces, read-write access and trading authentication are unchanged. The LongBridge snapshot consumer will adopt this separately; this PR does not enable sampling or authenticate broker account identity.
Validation: 79 tests and 21 subtests passed in the focused cloud/LongBridge auth suite; targeted Ruff and diff checks passed. Independent review found no material issues. All SDK calls in validation were mocked.