Skip to content

fix: distinguish closed traffic tag rejection causes #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Oct 2, 2026
Merged

fix: distinguish closed traffic tag rejection causes #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/diagnose_cached_stage_failure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@
"environment",
"network",
"quota",
"traffic_tag_length",
"traffic_tag_format",
"traffic_tag_conflict",
"traffic_tag_url_disabled",
)
_REASON_PATTERNS = {
"act_as": re.compile(r"iam\.serviceaccounts\.actas|actas|service account user", re.I),
Expand All @@ -47,6 +51,10 @@
"environment": re.compile(r"environment variable|environment configuration|env var", re.I),
"network": re.compile(r"\bvpc\b|network|subnet|connector", re.I),
"quota": re.compile(r"quota|resource[_ ]exhausted|limit exceeded", re.I),
"traffic_tag_length": re.compile(r"traffic[^\n]*tags?[^\n]*(length|longer|shorter|characters|too long|at most|at least)", re.I),
"traffic_tag_format": re.compile(r"traffic[^\n]*tags?[^\n]*(format|lowercase|dns|regex|valid)", re.I),
"traffic_tag_conflict": re.compile(r"traffic[^\n]*tags?[^\n]*(reserved|already|duplicate|unique)", re.I),
"traffic_tag_url_disabled": re.compile(r"traffic[^\n]*tags?[^\n]*(url[^\n]*disabled|disabled[^\n]*url|unsupported|not supported)", re.I),
}
_KNOWN_RPC_STATUS_CODES = frozenset(range(17))
_AUDIT_MESSAGE_TERMS = (
Expand Down Expand Up @@ -381,6 +389,7 @@ def summarize(
"service_readable": service_ok,
"target_matches": target_matches,
"diagnostic_tag_budget_ok": tag_budget_ok,
"service_name_length": len(expected_service) if target_matches else None,
"failure_subcategory": "combined_traffic_tag_service_name_length" if combined_tag_name_error else "none",
"combined_traffic_tag_service_name_length_error_observed": combined_tag_name_error,
"service_ready": _ready(service),
Expand Down
17 changes: 15 additions & 2 deletions tests/test_cached_stage_failure_diagnostic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ def test_summary_exposes_only_closed_statuses_counts_and_categories():
"service_readable": True,
"target_matches": True,
"diagnostic_tag_budget_ok": True,
"service_name_length": len(PRIVATE_SERVICE),
"failure_subcategory": "none",
"combined_traffic_tag_service_name_length_error_observed": False,
"service_ready": True,
Expand Down Expand Up @@ -150,7 +151,7 @@ def test_summary_exposes_only_closed_statuses_counts_and_categories():
(
"traffic[].tag: traffic tag [TAG] and service name [SERVICE] together are too long. "
"Combined traffic tag and service name cannot exceed 46 characters.",
["invalid_name"],
["invalid_name", "traffic_tag_length"],
),
("opaque upstream diagnostic", ["unknown"]),
],
Expand All @@ -159,6 +160,18 @@ def test_error_text_is_reduced_to_fixed_reason(message, expected):
assert diagnostic._classify([message]) == expected


@pytest.mark.parametrize(("message", "reason"), [
("Traffic tag [PRIVATE_TAG] should be at most one character long", "traffic_tag_length"),
("Traffic tag [PRIVATE_TAG] must have a valid DNS format", "traffic_tag_format"),
("Traffic tag [PRIVATE_TAG] is reserved", "traffic_tag_conflict"),
("Traffic tags are not supported when the URL is disabled", "traffic_tag_url_disabled"),
])
def test_traffic_tag_rejections_remain_closed(message, reason):
summary = diagnostic._classify([message])
assert summary == [reason]
assert "PRIVATE_TAG" not in json.dumps(summary)


def test_missing_logging_permission_is_reported_without_guessing_failure_category():
service, revisions, policy, jobs, audit = _evidence("permission denied")
summary = diagnostic.summarize(
Expand Down Expand Up @@ -199,7 +212,7 @@ def test_combined_traffic_tag_length_is_closed_subcategory_and_budget_stays_priv
audit_entries=audit,
audit_status="ok",
)
assert summary["failure_categories"] == ["invalid_name"]
assert summary["failure_categories"] == ["invalid_name", "traffic_tag_length"]
assert summary["failure_subcategory"] == "combined_traffic_tag_service_name_length"
assert summary["combined_traffic_tag_service_name_length_error_observed"] is True
assert summary["diagnostic_tag_budget_ok"] is True
Expand Down
Loading