Repository navigation
[WIP] Clarify transported mass in partial OT - #902
JaylenTang wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 97.01% 94.57% -2.45%
==========================================
Files 130 130
Lines 26879 26879
==========================================
- Hits 26078 25420 -658
- Misses 801 1459 +658 🚀 New features to boost your workflow:
|
rflamary
left a comment
There was a problem hiding this comment.
Thanks for the PR @JaylenTang , I have some suggestions below about shortening the user guide and about the new info in the exmaple.
| application, or validation suited to that application, can inform the choice. | ||
| Inspecting several feasible masses helps show the consequences of that choice. | ||
|
|
||
| The :ref:`2D partial Wasserstein example |
There was a problem hiding this comment.
this discussion is interesting but much too detailed for a user's guide. you can eitehr move it to the exmaple file where it makes more sens or remove it. only keep a sentence with areference to the example please.
| ) | ||
|
|
||
| print("\nExact partial Wasserstein mass study (raw transport costs):") | ||
| print(" m cost source in source out target in target out any out") |
There was a problem hiding this comment.
names are unclear please dont' use in and out that can mean source/target in OT but inlier outlier possibly . Actually it would porably be more clear with aplot (and maybe more valyues of m?) where you can have larger legends for the plots
Types of changes
Documentation and example update.
Motivation and context / Related issue
Related to #890.
Hi, I've put together a first version of the transported-mass explanation proposed in #890.
The guide already gives the partial OT formulation, and the 1D example shows different numbers of transported samples. This extends the existing 2D example to help explain what
mmeans for weighted distributions:m=0.25,0.5,0.75, and1on the same data with a fixed seed.It uses the existing solver and keeps the original entropic and Gromov-Wasserstein sections and attribution. The example also checks transported mass, marginal limits, and the balanced OT endpoint.
I'd appreciate feedback on the scope and whether this fits best in the existing guide and example or in a separate focused example. Thanks!
How has this been tested (if it applies)
Local checks on Python 3.12 with the NumPy CPU backend:
pytest test/ -q --doctest-modules --disable-warnings: 1,524 passed, 134 skipped, 4 expected failures.test/conftest.py: 20 passed.PR checklist
This is a draft for feedback on the documentation and example.