Skip to content

raise actionable errors for missing DA parameters #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

raise actionable errors for missing DA parameters #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
- Fix `ot.gromov.fused_unbalanced_across_spaces_divergence` crashing with a `TypeError` when only one of the sample or feature dual pairs was passed in `init_duals` (PR #888)
- Raise errors instead of printing a message and returning `None` or dummy values in `ot.datasets.make_data_classif` (unknown dataset), `ot.stochastic.solve_semi_dual_entropic` (unknown method) and `ot.mapping.nearest_brenier_potential_*` (missing CVXPY), and emit warnings instead of prints in `ot.gaussian.bures_barycenter_fixpoint`, `ot.regpath` and `ot.partial.entropic_partial_wasserstein` (PR #888)
- Fix docstring errors (wrong or duplicated parameters, typos) and fix the file patterns of the ruff hooks in `.pre-commit-config.yaml` (PR #888)
- Raise `ValueError` naming every missing required input in the `ot.da` transport estimators (`BaseTransport` fit and sample/label transforms, `LinearTransport` transforms also used by `LinearGWTransport`, `SinkhornLpl1Transport` and `SinkhornL1l2Transport` fits, `MappingTransport` fit/transform, `UnbalancedSinkhornTransport.fit` and `JCPOTTransport` fit/transform/label transforms) instead of printing the parameter names and returning an unfitted estimator or `None`. Checks run before backend selection and before `JCPOTTransport.fit` unpacks its source lists. Optional labels stay optional, and `ot.utils.check_params` still returns a boolean (Issue #528)

## 0.9.7.post1

Expand Down
Loading
Loading