Repository navigation
[MRG] Stabilize simplex projection against large common offsets - #880
Open
AHMETHAKANBEZIR1 wants to merge 5 commits into
Open
AHMETHAKANBEZIR1 wants to merge 5 commits into
AHMETHAKANBEZIR1 wants to merge 5 commits into
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
…tion-stability # Conflicts: # RELEASES.md
…tion-stability # Conflicts: # RELEASES.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #879.
Simplex projection is invariant to a common offset per column. Center floating inputs before sorting and thresholding so equal large float32/float64 inputs retain unit mass instead of producing all zeros. Integer inputs keep their existing path. This change does not address the separate sparse projection or change validation for nonpositive simplex radii.
Validation
Full package, GPU, TensorFlow, CuPy, compilation and full project documentation were not run. The regression reference uses floating np.full rather than integer-inheriting full_like; that initial test-oracle mistake was corrected before the final baseline and validation runs.
Contribution disclosure
Prepared autonomously with OpenAI Codex, including implementation and tests. No independent human review has been performed. Codex is recorded as a commit co-author.
Current base validation
Merged master
c02a25c, retaining both release-note entries and upstream device-allocation fixes. Complete utility module: 124 passed with NumPy; 190 passed with NumPy/PyTorch 2.9.1 CPU. Focused simplex tests in the NumPy/TensorFlow environment: 23 passed. Applicable configured hooks and diff checks pass. This update did not run the full package suite or GPU tests; CI is pending.20 October master integration
Merged current master
5cb82c9, preserving both the existing fix release note and the upstream API-documentation release note. The only conflict was inRELEASES.md; production code and regression tests merged without conflict. Complete utility module with NumPy: 124 passed. Focused simplex tests with NumPy/TensorFlow: 23 passed. Applicable configured pre-commit hooks and diff checks pass. These are Windows/Python 3.12 CPU checks; no new full-package, GPU, or PyTorch run is claimed for this maintenance update. GitHub CI is pending. Autonomous Codex contribution disclosure above still applies.20 October CI completion check
Current-head CircleCI documentation build and documentation artifact checks now pass. The labeler also passes. No remote unit-test result is present in the reported contexts; the local numerical test results above remain the validation evidence. The pull request remains open pending maintainer review.