Repository navigation
Handle both endpoints in sample-ratio splitting - #878
Open
AHMETHAKANBEZIR1 wants to merge 7 commits into
Open
AHMETHAKANBEZIR1 wants to merge 7 commits into
AHMETHAKANBEZIR1 wants to merge 7 commits into
Conversation
Return both endpoint distributions and matching selectors before accessing a boundary weight beyond the end of the array. Co-authored-by: Codex <noreply@openai.com>
…dpoint # Conflicts: # RELEASES.md
…dpoint # Conflicts: # RELEASES.md
AHMETHAKANBEZIR1
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #877. At
ratio=1,split_sample_ratiosearches past the final weight and raises an indexing error. Atratio=0, TensorFlow's scalarsearchsortedpath also raises before returning the empty/full split.Return the full and empty distributions directly at both supported endpoints, after the existing optional permutation. Preserve the original weights, backend, shapes and selectors. Interior-ratio weight computation is unchanged.
Validation after updating against master
c02a25c:test/test_utils.py: 122 passed with NumPy; 186 passed with NumPy/PyTorch 2.9.1 CPU; 154 passed and 32 existing interior-ratio skips with NumPy/TensorFlow. Existing warnings were retained.git diff --checkpass. Both upstream and PR release-note entries were preserved during the merge.Windows/Python 3.12.14; native POT extensions were built locally. The full package suite, full documentation/gallery, GPU, JAX and CuPy were not run for this update. No new handling of degenerate distributions is claimed.
This contribution was investigated, implemented and validated autonomously with Codex assistance on behalf of AHMETHAKANBEZIR1. It has not received independent human review. Local results do not assert upstream CI success.
20 October master integration
Merged current master
5cb82c9, preserving both the existing fix release note and the upstream API-documentation release note. The only conflict was inRELEASES.md; production code and regression tests merged without conflict. Complete utility module with NumPy: 122 passed. Complete utility module with NumPy/TensorFlow: 154 passed, 32 pre-existing skips, one median-detachment warning. Applicable configured pre-commit hooks and diff checks pass. These are Windows/Python 3.12 CPU checks; no new full-package, GPU, or PyTorch run is claimed for this maintenance update. GitHub CI is pending. Autonomous Codex contribution disclosure above still applies.20 October CI completion check
Current-head CircleCI documentation build and documentation artifact checks now pass. The labeler also passes. No remote unit-test result is present in the reported contexts; the local numerical test results above remain the validation evidence. The pull request remains open pending maintainer review.