Skip to content

fix: sender rules have to apply on user and its aliases - #574

Open
guillaumedc wants to merge 1 commit into
mainfrom
fix/sender-rules-to-apply-on-aliases-#554
Open

fix: sender rules have to apply on user and its aliases#574
guillaumedc wants to merge 1 commit into
mainfrom
fix/sender-rules-to-apply-on-aliases-#554

Conversation

@guillaumedc

@guillaumedc guillaumedc commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related issue(s)

#554

How to test manually

  • on main:
    • Authorize/ban senders for an account email
    • Create an alias for this account
    • Go to Authorized senders
    • The authorized/banned senders are applied only to the base account, not the alias
  • on this branch:
    • Authorize/ban senders for an account email
    • Create an alias for this account
    • Go to Authorized senders
    • The authorized/banned senders are applied to the base account and the alias

Reviewer checklist

  • Code is manually tested
  • Interface works on both mobiles and big screens
  • Interface works on both Firefox and Chrome
  • Tests are up to date
  • Documentation is up to date
  • Pull request has been reviewed and approved

@guillaumedc guillaumedc added this to the Version 3.0 milestone Aug 7, 2026
@guillaumedc guillaumedc self-assigned this Aug 7, 2026
@guillaumedc
guillaumedc force-pushed the fix/sender-rules-to-apply-on-aliases-#554 branch from 68f7086 to f4d894e Compare August 7, 2026 15:17
@github-actions

github-actions Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

170 tests   170 ✅  24s ⏱️
 19 suites    0 💤
  1 files      0 ❌

Results for commit 3e4bf23.

♻️ This comment has been updated with latest results.

@guillaumedc
guillaumedc force-pushed the fix/sender-rules-to-apply-on-aliases-#554 branch from f4d894e to c448160 Compare August 7, 2026 15:28
@guillaumedc
guillaumedc marked this pull request as draft August 7, 2026 15:34
@guillaumedc guillaumedc linked an issue Aug 7, 2026 that may be closed by this pull request
Creating alias don't apply existing sender rules from the origin account #554
Open
@guillaumedc
guillaumedc force-pushed the chore/tests-3 branch 2 times, most recently from b752928 to e1110f8 Compare August 10, 2026 07:35
@guillaumedc
guillaumedc force-pushed the fix/sender-rules-to-apply-on-aliases-#554 branch from c448160 to beb2846 Compare August 10, 2026 12:52
@guillaumedc
guillaumedc marked this pull request as ready for review August 10, 2026 12:53
@guillaumedc
guillaumedc changed the base branch from chore/tests-3 to main August 25, 2026 12:56
@gitguardian

gitguardian Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@guillaumedc
guillaumedc changed the base branch from main to chore/tests-3 August 25, 2026 13:23
@guillaumedc
guillaumedc force-pushed the fix/sender-rules-to-apply-on-aliases-#554 branch from beb2846 to db1c557 Compare August 26, 2026 07:07
@guillaumedc
guillaumedc changed the base branch from chore/tests-3 to main August 26, 2026 07:08
@guillaumedc
guillaumedc force-pushed the fix/sender-rules-to-apply-on-aliases-#554 branch 3 times, most recently from 99cd183 to b7d464f Compare August 28, 2026 13:19
@guillaumedc
guillaumedc force-pushed the fix/sender-rules-to-apply-on-aliases-#554 branch from b7d464f to 98eb6be Compare September 23, 2026 15:05
@marien-probesys marien-probesys removed this from the Version 2.8 milestone Sep 24, 2026
marien-probesys
marien-probesys reviewed Sep 25, 2026
View reviewed changes

@marien-probesys marien-probesys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques retours rapides avant de partir en weekend. Aussi y a des changements liés dans #644 (pas grand-chose), donc attention aux conflits

Comment thread app/src/Service/UserService.php Outdated
Comment thread app/src/Service/UserService.php
public function updateAliasGroupsAndPolicyFromUser(User $user): void
{
$originalUserGroups = $originalUser->getGroups()->toArray();
$parentUser = $user->getOriginalUser();

@marien-probesys marien-probesys Sep 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La PR #567 introduit une méthode User::getMainUser(), ce serait utile de l’utiliser ici.

Comment thread app/src/Service/UserService.php Outdated
$originalUserGroups = $originalUser->getGroups()->toArray();
$parentUser = $user->getOriginalUser();
if ($parentUser) {
// If there is a parent, current user is an alias => update using groups and rules from parent

@marien-probesys marien-probesys Sep 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J’expliciterai qu’on a passé un alias en paramètre et qu’on update donc que cet utilisateur.

@guillaumedc guillaumedc Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne suis pas sûr de comprendre la modification attendue.

J'ai fait une proposition.

Comment thread app/src/Service/UserService.php Outdated
$this->updateGroups($user, $parentUser->getGroups()->toArray());
$this->updateSenderRules($user, $parentUser->getSenderRules()->toArray());
} else {
// Otherwise it's an original user

@marien-probesys marien-probesys Sep 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et ici qu’on a passé un original user (c’est ce qui est dit) et qu’on synchro donc tous ses alias

@guillaumedc guillaumedc Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pareil ici.

Comment thread app/src/Service/UserService.php
/**
* @param array<Group> $userGroups
*/
private function updateGroups(User $user, array $userGroups): void

@marien-probesys marien-probesys Sep 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J’ai pas eu le temps de relire les autres modifs de ce fichier, ni les tests. Bon weekend ;)

@guillaumedc
guillaumedc force-pushed the fix/sender-rules-to-apply-on-aliases-#554 branch from 98eb6be to f2983e9 Compare September 28, 2026 13:06
@guillaumedc
guillaumedc force-pushed the fix/sender-rules-to-apply-on-aliases-#554 branch from f2983e9 to 3e4bf23 Compare September 28, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marien-probesys marien-probesys marien-probesys left review comments
@ctresvaux ctresvaux Awaiting requested review from ctresvaux

At least 1 approving review is required to merge this pull request.

Assignees

@guillaumedc guillaumedc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creating alias don't apply existing sender rules from the origin account

2 participants

@guillaumedc @marien-probesys