fix: improved regex that doesn't exclude other windows languages - #59
Open
Nathan-Wrpt wants to merge 1 commit into
Open
Nathan-Wrpt wants to merge 1 commit into
Nathan-Wrpt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated
PowerPlanServiceto parse power plan entries using their GUID format instead of the EnglishPower Scheme GUID:label. This fixes power plan detection on different languages Windows installations.Type of Change
Validation
Automated tests could not be run because
.NETwas unavailable in the development environment. A localized-output test was created locally but is not included in this pull request.Security and Risk Notes
No impact on elevation, process control, power plan operations, or persisted configuration. The change only affects parsing of
powercfg /listand/getactiveschemeoutput.Checklist