CLAUDE.md: fix monitor-ci.sh doc mismatch, no --commit flag exists - #116
Open
jnasbyupgrade wants to merge 1 commit into
Open
CLAUDE.md: fix monitor-ci.sh doc mismatch, no --commit flag exists#116jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
The script only ever took positional args ([repos] [branch] [sha_pgxntool_test] [sha_pgxntool]) - the --commit SHA flag text appears to have crept in from ../ai/CLAUDE.md's general gh CLI advice (gh run list/gh pr checks do take --commit) getting conflated with this script's own interface. An agent following the doc literally invoked `monitor-ci.sh --commit SHA`, which silently misparsed and hung until timeout polling a nonexistent branch. Companion fix in pgxntool-test#82 (monitor-ci.sh itself, plus its own SKILL.md).
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion fix to
pgxntool-test#82. This repo'sCLAUDE.mddescribedmonitor-ci.shas taking a--commit SHAflag, but the script (whichlives in the pgxntool-test checkout) only ever took positional args
(
[repos] [branch] [sha_pgxntool_test] [sha_pgxntool]). The flag textappears to have crept in from
../ai/CLAUDE.md's generalghCLI advice(
gh run list/gh pr checksdo take--commit) getting conflated withthis script's own interface — see pgxntool-test#82 for the full
incident writeup and the script/SKILL.md side of the fix.
Test plan