Repository navigation
Conversation
eli-r-ph
marked this pull request as ready for review
October 10, 2026 17:11
eli-r-ph
force-pushed
the
v1-sync-main
branch
from
October 10, 2026 23:35
5f2f116 to
b4e9c49
Compare
eli-r-ph
force-pushed
the
v1-capture-api-fixes
branch
from
October 10, 2026 23:35
6982671 to
0c99129
Compare
…xception properties
An invalid caller uuid is still replaced with a generated UUIDv7, but the SDK now logs one warning that names the rule instead of an error that echoes the value. An empty string counts as unset and gets a generated uuid without a log. Client and AsyncClient share one helper.
A disable_geoip argument now fills $geoip_disable as the event's own value: above context tags, super_properties and the client setting, and below a $geoip_disable in the call's properties. disable_geoip=False now sends $geoip_disable: false. Client and AsyncClient share the layer in _build_event_defaults.
eli-r-ph
force-pushed
the
v1-sync-main
branch
from
October 11, 2026 20:17
b4e9c49 to
f553d2a
Compare
eli-r-ph
force-pushed
the
v1-capture-api-fixes
branch
from
October 11, 2026 20:17
0c99129 to
161a339
Compare
dustinbyrne
approved these changes
Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Stacked on #1044. Five small 8.0 fixes, one commit each, so request arguments, exceptions, session IDs, uuids and GeoIP behave like the other v1 SDKs.
Changes
request.postandrequest.flagstake keyword-only arguments afterpathorhost, so a 7.x positional call raisesTypeErrorinstead of binding the wrong parameter.capture_exception(level=...)sets$exception_level; an unknown level falls back toerror.propertiescan no longer override the reserved exception properties.$session_idor$window_idis dropped with one warning that never includes the value.uuidis replaced with a v7 uuid and one warning that never includes the value.disable_geoipbeats context tags andsuper_properties, andFalseis sent as$geoip_disable: false.💚 How did you test it?
disable_geoipprecedence table.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Written with Cursor (Claude Opus 5.5) under the direction of the assignee.
🤖 Generated with Claude Code