Repository navigation
Conversation
3 of 20 tasks
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
from
October 8, 2026 00:08
44123ba to
956c711
Compare
eli-r-ph
force-pushed
the
v1-capture-redirects
branch
3 times, most recently
from
October 8, 2026 16:25
6eb24c5 to
da670e8
Compare
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
2 times, most recently
from
October 8, 2026 18:13
a1ba868 to
6e21be6
Compare
eli-r-ph
force-pushed
the
v1-capture-redirects
branch
from
October 8, 2026 18:13
da670e8 to
638eb11
Compare
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
from
October 8, 2026 21:12
6e21be6 to
3fbfd0e
Compare
eli-r-ph
force-pushed
the
v1-capture-redirects
branch
from
October 8, 2026 21:12
638eb11 to
5e6c45a
Compare
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
from
October 8, 2026 22:54
3fbfd0e to
4194471
Compare
eli-r-ph
force-pushed
the
v1-capture-redirects
branch
2 times, most recently
from
October 8, 2026 23:40
19064bc to
bcd36eb
Compare
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
from
October 8, 2026 23:40
4194471 to
307bb9e
Compare
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
from
October 10, 2026 00:32
307bb9e to
ec37610
Compare
eli-r-ph
force-pushed
the
v1-capture-redirects
branch
2 times, most recently
from
October 10, 2026 03:19
be748d9 to
ea73def
Compare
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
from
October 10, 2026 03:19
ec37610 to
5718a37
Compare
eli-r-ph
force-pushed
the
v1-capture-redirects
branch
from
October 10, 2026 23:35
ea73def to
f7f2b74
Compare
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
from
October 10, 2026 23:35
5718a37 to
796579a
Compare
_post_v1 disables automatic redirects and resends the batch only on a 307 or 308 to the origin of host, at most 5 times. Any other redirect returns as a terminal failure. Covers the sync client and the async client, which lost its v0 same-origin guard when v1 became the only path.
eli-r-ph
force-pushed
the
v1-capture-redirects
branch
from
October 11, 2026 20:17
f7f2b74 to
c107c49
Compare
eli-r-ph
force-pushed
the
v1-sdk-identity
branch
from
October 11, 2026 20:17
796579a to
21207f7
Compare
eli-r-ph
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Stacked on #1034. The v1 send path followed any redirect, so a
307or308from the ingestion host could make the SDK resend event data to another host or over plain HTTP. The 7.x async client had a guard for this, which was lost when v0 was removed. This PR restores it for both clients.Changes
307or308only to the origin ofhost, at most 5 times, with the same body and headers.on_errorwith the redirect status.💚 How did you test it?
302, send only one request.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Written with Cursor (Claude) under the direction of the assignee. Turning redirects off entirely was rejected because it would break same-origin proxies.
🤖 Generated with Claude Code