Repository navigation
Conversation
Generated-By: PostHog Desktop Task-Id: 651bf7d9-01f4-4d75-8583-868e29fdd314
|
[Medium risk] Adds a property to MCP server analytics events. The PR appears safe to merge. Reviews (1) · Last reviewed commit: "feat(mcp): add interface property to ser..." · Reviewed by Greptile |
posthog-python Compliance ReportDate: 2026-10-07T12:36:45.119958+00:00 ✅ All Tests Passed!121/121 tests passed Capture_V1 Tests✅ 95/95 tests passed View Details
Capture_Ai Tests✅ 5/5 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
Feature_Flags_Local_Evaluation Tests✅ 4/4 tests passed View Details
|
There was a problem hiding this comment.
Not approved — this change needs a human reviewer.
Re-adding the stamphog label gives the same result unless the changed files change.
Stamphog can't auto-review this pull request because two gates refused it. The deny-list gate matched public_api, since the change adds a new INTERFACE attribute in posthog/mcp/constants.py and a matching line in references/public_api_snapshot.txt. The tier gate classified it as T2-never (a cross-cutting feature across 5 files), which is a category that is never handled automatically.
Size was not the problem, so splitting the PR won't change the outcome. The author should ask a human reviewer, ideally someone who owns the public API surface of the MCP module, to review it.
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✗ | matches: public_api |
| size | ✓ | 8L, 2F substantive, 16L/5F incl. docs/generated/snapshots — within ceiling |
| tier | ✗ | classified as T2-never: T2-never (16L, 5F, cross-cutting, feat) |
| stamphog 2.4.1 | .stamphog/policy.yml @ unknown · reviewed head 5ad2cb9 |
💡 Motivation and Context
Why: WebMCP events identify their interface, but MCP server events do not. This gap prevents one consistent interface breakdown.
This change sets
$mcp_interfacetomcpon MCP server events and their$exceptionsiblings. It also adds a patch changeset.The shared MCP Analytics specification permits this property but does not define it yet.
💚 How did you test it?
posthogwith warnings treated as errors.📝 Checklist
If releasing new changes
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Codex in PostHog Desktop implemented and tested this change. The value
mcppairs with the existingwebmcpvalue.Created with PostHog Desktop