Repository navigation
Conversation
3 of 20 tasks
eli-r-ph
force-pushed
the
v1-capture-harness
branch
from
October 7, 2026 17:43
f2faf4d to
743d8ca
Compare
eli-r-ph
force-pushed
the
v1-capture-ai-personless-option
branch
from
October 7, 2026 17:43
3f09f03 to
5e3fddc
Compare
Contributor
Author
|
@greptileai review |
eli-r-ph
marked this pull request as ready for review
October 7, 2026 20:44
dustinbyrne
approved these changes
Oct 8, 2026
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
The expanded compliance matrix and adapter forwarding look sound. Existing CI exercises both capture lanes across all three codecs. One small documentation follow-up: the standalone adapter-test setup needs the zstd extra.
AI-assisted review.
eli-r-ph
force-pushed
the
v1-capture-harness
branch
from
October 8, 2026 16:25
743d8ca to
ca9c26c
Compare
eli-r-ph
force-pushed
the
v1-capture-ai-personless-option
branch
from
October 8, 2026 16:25
5e3fddc to
09f7144
Compare
eli-r-ph
force-pushed
the
v1-capture-harness
branch
from
October 8, 2026 18:13
ca9c26c to
e743d1e
Compare
eli-r-ph
force-pushed
the
v1-capture-ai-personless-option
branch
from
October 8, 2026 18:13
09f7144 to
1355d44
Compare
eli-r-ph
force-pushed
the
v1-capture-harness
branch
from
October 8, 2026 21:12
e743d1e to
78973e7
Compare
eli-r-ph
force-pushed
the
v1-capture-ai-personless-option
branch
2 times, most recently
from
October 8, 2026 22:54
316f808 to
b46dbfa
Compare
eli-r-ph
force-pushed
the
v1-capture-harness
branch
from
October 8, 2026 22:54
78973e7 to
9dcf4df
Compare
The adapter now advertises capture_ai_v1 and event_options, passes options and uuids through unchanged, and takes its codec from COMPRESSION. The workflow runs the harness containers directly in a gzip/deflate/zstd matrix, so it no longer needs pull-requests: write.
The standalone adapter-test setup installs the zstd extra, matching CI.
eli-r-ph
force-pushed
the
v1-capture-harness
branch
from
October 8, 2026 23:40
9dcf4df to
d31608d
Compare
eli-r-ph
force-pushed
the
v1-capture-ai-personless-option
branch
from
October 8, 2026 23:40
b46dbfa to
233dc8a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
optionsback into legacy$properties. Since the options PRs earlier in this stack, the SDK takesoptions=directly, so this fold tests a path users no longer need.pull-requests: write. That step failed on #1019 for reasons unrelated to the SDK.This PR runs harness 1.13.1 with every capture suite the SDK supports, once per codec.
Changes
capture_ai_v1andevent_options. Both suites now run against this SDK./captureand/capture_aishare one handler. It passesoptions,propertiesand a supplieduuidto the SDK unchanged, and returns the uuid the SDK sent.COMPRESSION(gzip, deflate or zstd, default gzip). It advertises only thatencoding_<codec>capability and uses the codec on both lanes. An unknown value stops the adapter at startup.enable_compressionflag but one test per codec, so CI runs one job per codec. There is no brotli job, because the SDK has no brotli support.COMPRESSIONto the adapter.contents: read.zstdextra.docker-compose.ymluses harness 1.13.1 and passesCOMPRESSION.No SDK code changes. A behavior change for the harness only:
/capturenow forwards a supplied uuid, as/capture_aialready did.💚 How did you test it?
test_health_and_init_use_one_codeccatches an adapter that advertises the wrongencoding_capability, or that sets the codec on only one lane.test_capture_passes_options_and_uuid_unchangedcatches an adapter that rewrites options, drops the uuid, or returns a uuid other than the SDK's.encoding_gzip, options dropped, the AI lane codec left unset.📝 Checklist
If releasing new changes
sampo addto generate a changeset fileNone needed: this changes CI and the compliance adapter only.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Written with Cursor (Claude Opus) under the direction of the assignee. Skills used:
writing-pr-descriptions.Agent calls worth review:
docker compose upwithoutCOMPRESSIONbehaves as before.