Conversation
Contributor
|
[Low risk] Documents a new public API function in the snapshot. The PR appears safe to merge. Reviews (1) · Last reviewed commit: "chore(ci): add get_tool_input_properties..." |
Contributor
posthog-python Compliance ReportDate: 2026-10-06T10:18:45.878278+00:00 ✅ All Tests Passed!121/121 tests passed Capture_V1 Tests✅ 95/95 tests passed View Details
Capture_Ai Tests✅ 5/5 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
Feature_Flags_Local_Evaluation Tests✅ 4/4 tests passed View Details
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The "Public API snapshot" CI job has been red on
mainsince 6d83875 (#1005), e.g. https://github.com/PostHog/posthog-python/actions/runs/37441074391, so every open PR inherits the failing check.#1005 changed
.github/scripts/check_public_api.pyso functions re-exported from private SDK modules count as public API.posthog.mcp.get_tool_input_propertiesis one of those: #989 added it to__all__inposthog/mcp/__init__.py(imported from._tool_input), but the snapshot regenerated in #1005 missed that line.The export is intentional, so this adds the missing line to
references/public_api_snapshot.txtrather than dropping the export. No shipped code changes. This unblocks the snapshot check for every open PR.💚 How did you test it?
I ran
make public_api_snapshotthenmake public_api_checklocally in the locked dev environment (uv sync --extra dev --extra test, griffe 2.0.2). The regenerated snapshot differs by exactly one added line:The check passes with the updated snapshot.
📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
DRI: @ioannisj
Autonomy: Human-driven (agent-assisted)