Repository navigation
mod_EmuELEC: wrap get_controls only once - #359
Merged
Merged
Conversation
Sourcing mod_EmuELEC.txt a second time wrapped the wrapper: its _pm_get_controls_orig became the wrapper itself, so get_controls called itself until bash crashed. Mystik Belle, The Flayed Man and The Sphinx of Time source it twice; they call get_controls in between, so only a port calling it after the second source would crash, but nothing stopped that. tests/test_mod_files.py runs the wrapper sourced once, twice and three times (bash crashes without the check), and with a small config it must keep. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcing mod_EmuELEC.txt a second time wrapped the wrapper: its _pm_get_controls_orig became the wrapper itself, so get_controls called itself until bash crashed. Mystik Belle, The Flayed Man and The Sphinx of Time source it twice; they call get_controls in between, so only a port calling it after the second source would crash, but nothing stopped that.
tests/test_mod_files.py runs the wrapper sourced once, twice and three times (bash crashes without the check), and with a small config it must keep.