Repository navigation
mod_EmuELEC: also clear oversized sdl_controllerconfig for ports calling get_controls before sourcing - #358
Merged
Merged
Conversation
…ing get_controls before sourcing
The existing E2BIG fix wraps get_controls, but the wrapper is only installed if the mod file is sourced before get_controls runs. Several ports (e.g. Sonic 1, Sonic 2, Sonic CD) call get_controls first and source mod_${CFW_NAME}.txt afterwards. In that case sdl_controllerconfig still holds the full gamecontrollerdb, gets exported as SDL_GAMECONTROLLERCONFIG, and every execve() fails with “Argument list too long”.
This adds a one-line check right after the wrapper that clears the variable when it is already oversized at source time. Both call orders are now covered, and SDL still receives the mappings via SDL_GAMECONTROLLERCONFIG_FILE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing E2BIG fix wraps get_controls, but the wrapper is only installed if the mod file is sourced before get_controls runs. Several ports (e.g. Sonic 1, Sonic 2, Sonic CD) call get_controls first and source mod_${CFW_NAME}.txt afterwards. In that case sdl_controllerconfig still holds the full gamecontrollerdb, gets exported as SDL_GAMECONTROLLERCONFIG, and every execve() fails with “Argument list too long”.
This adds a one-line check right after the wrapper that clears the variable when it is already oversized at source time. Both call orders are now covered, and SDL still receives the mappings via SDL_GAMECONTROLLERCONFIG_FILE.