Fix HashableProp tests - #2801
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 501fd4d | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
6 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
6 ns/iter (± 0) |
1 ns/iter (± 0) |
6 |
lotr_graph/graph_latest |
5 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
7958024 ns/iter (± 55539) |
1564816 ns/iter (± 35303) |
5.09 |
lotr_graph_window_100/num_nodes |
18 ns/iter (± 0) |
5 ns/iter (± 0) |
3.60 |
lotr_graph_window_100_materialise/materialize |
7970525 ns/iter (± 36528) |
1669150 ns/iter (± 10700) |
4.78 |
lotr_graph_window_10/has_node_existing |
140 ns/iter (± 8) |
62 ns/iter (± 11) |
2.26 |
lotr_graph_window_10_materialise/materialize |
3472909 ns/iter (± 29233) |
971980 ns/iter (± 4278) |
3.57 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
2282841 ns/iter (± 47866) |
334634 ns/iter (± 1287) |
6.82 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
148 ns/iter (± 8) |
62 ns/iter (± 14) |
2.39 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1514702 ns/iter (± 7357) |
230399 ns/iter (± 2617) |
6.57 |
lotr_graph_window_50_layered/num_edges_temporal |
148014 ns/iter (± 2610) |
70121 ns/iter (± 7586) |
2.11 |
lotr_graph_window_50_layered/has_node_existing |
397 ns/iter (± 17) |
129 ns/iter (± 12) |
3.08 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/graph_latest |
93010 ns/iter (± 1045) |
36649 ns/iter (± 916) |
2.54 |
lotr_graph_window_50_layered_materialise/materialize |
30741191 ns/iter (± 310090) |
3488825 ns/iter (± 24948) |
8.81 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
593084 ns/iter (± 6795) |
192686 ns/iter (± 1569) |
3.08 |
lotr_graph_persistent_window_50_layered/has_node_existing |
410 ns/iter (± 362) |
174 ns/iter (± 83) |
2.36 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
3337989 ns/iter (± 51098) |
1659940 ns/iter (± 19402) |
2.01 |
lotr_graph_persistent_window_50_layered/graph_latest |
147669 ns/iter (± 1622) |
57549 ns/iter (± 4809) |
2.57 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
52276793 ns/iter (± 456338) |
5298035 ns/iter (± 147912) |
9.87 |
This comment was automatically generated by workflow using github-action-benchmark.
fabubaker
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HashablePropwas using equality checks onPropinstead ofHashablePropWhy are the changes needed?
spurious test failure
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?