fix(oauth): include created_at in token responses - #36
Merged
Merged
Conversation
Doorkeeper's token response carried created_at, and the native Workplace app computes expiry as created_at + expires_in. Without the field the app reads zero, treats every token as expired at once, and refreshes and reconnects in a loop until it runs out of sockets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
created_at(unix seconds of issuance) to/auth/oauth/tokenresponses, alongsideexpires_in. Doorkeeper always sent it.Why
The native Workplace app computes token expiry as
created_at + expires_in. With the field absent it reads zero, so every periodic check finds the token expired: refresh, websocket reconnect, full data refetch, repeat. Observed on aplaceos-2.2609.1instance: 39 successful refreshes in ten minutes, 5,666 API requests in one minute, 663 websocket reconnections, then the app starved itself of sockets and froze. The server answered every refresh with 200 throughout.Tests
The token-exchange spec now asserts
created_atis present and within a minute of now.