Repository navigation
ci: add CodeQL scanning for C# - #1
Merged
Merged
Conversation
Every other C# repo in this workspace (TcgDex.CSharpSdk, PokemonBattleJournal, Tf2DemoSalvage) already runs this; WindowsDriverCore was the one gap despite already having secret scanning and Dependabot alerts on. No reason it was skipped is recorded anywhere - looks like an oversight rather than a decision. windows-latest rather than TcgDex.CSharpSdk's ubuntu-latest: this repository's automation layer is raw IUIAutomation COM and every project targets net10.0-windows, so it can only build where ci.yml already builds it. Full solution build (WindowsDriverCore.slnx) rather than a single project, because unlike TcgDex.CSharpSdk's one library multi-targeted three times, this repository's projects are genuinely different code and no single one stands in for the rest. No paths-ignore or query-filters yet. TcgDex.CSharpSdk's config excludes a System.Text.Json source-generator noise pattern, added only after a first real scan measured 212 alerts and traced all of them to generated code - there is no evidence yet that WindowsDriverCore has the same or any other noise pattern, so nothing is excluded until a real run says otherwise. Action versions looked up rather than copied from memory: checkout v7.0.1, setup-dotnet v6.0.0, codeql-action v4.37.9 (2026-09-08). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other C# repo here (TcgDex.CSharpSdk, PokemonBattleJournal, Tf2DemoSalvage) already runs CodeQL; this was the one gap despite already having secret scanning and Dependabot alerts on.
windows-latest, notubuntu-latestlike TcgDex.CSharpSdk's version — this repo's automation layer is raw IUIAutomation COM and every project targetsnet10.0-windows, so it can only build whereci.ymlalready builds it. Full solution build (WindowsDriverCore.slnx) rather than a single project, since these are genuinely different projects rather than one library multi-targeted three times.No
paths-ignore/query-filtersyet — TcgDex.CSharpSdk only added its exclusion after a first real scan measured 212 alerts and traced them to a source-generator noise pattern. Nothing excluded here until a real run says something needs it.Action versions looked up, not copied from memory: checkout v7.0.1, setup-dotnet v6.0.0, codeql-action v4.37.9.
🤖 Generated with Claude Code