Repository navigation
feat(chat): monitor reply quotes and a session-start DM ensure (TASK-4043) - #2309
Merged
Merged
Conversation
…43 r2) A Retry-After too large for a time.Duration (>= 9223372037s) wrapped negative and made the ensure retry hot. Seconds are now bounded before the multiply; zero, negative, absent and overflowing values all wait the 120s default, and the largest value that fits is honoured. Claude-Session: https://claude.ai/code/session_017ofcsFmgnoVDPxeHwuxCjg
…43 r3) The overflow rows are int64 and skip where int cannot hold them; the rows run with a temp HOME. Claude-Session: https://claude.ai/code/session_017ofcsFmgnoVDPxeHwuxCjg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat 2a.6, monitor delivery (TASK-4043). #2305 (TASK-4041) shipped most of this task's body. This PR adds the two pieces it didn't ship: the reply quote in the monitor line, and a session-start owner-agent DM ensure.
Already on main (82f81ee). Each body bullet with its evidence:
chat=trueon the stream:internal/cli/client.go:949. Agent and worker headers:internal/cli/client.go:3041and:3045. The monitor runspad watch --stream --for-session(plugin/scripts/pad-monitor.sh:119).cmd/pad/cmd_watch_chat.go:35. Membership is re-checked server-side on every read (internal/server/handlers_chat.go:193).pad chat showpointer:cmd/pad/cmd_watch_chat.go:89,:96.cmd/pad/cmd_watch_chat.go:130) anddelivered_seqack (:65)./me/chat/unreadsummary on reconnect orsync_required:cmd/pad/cmd_watch_chat.go:75,:408, andcmd/pad/cmd_watch.go:630.cmd/pad/cmd_watch_chat_test.go:98(TestFormatChatLineEnvelopes),:160(TestMonitorDedupeAndDeliveredAck),:243(TestReconnectPrintsUnreadSummary).New in this PR
(replying to #<seq>: "<excerpt>")from the server'sConversationQuote. The quoted body is never fetched or printed. The quote is collapsed, appended outside the 2000-rune cut, and omitted when it is nil or deleted. It appears in both framings.pad watchhelp,docs/api.md,skills/pad/SKILL.md,plugin/skills/pad/SKILL.mdandplugin/skills/connect/SKILL.md.Not in scope: Dave's requirement that chat be visible to the human at the terminal is TASK-4071, which is blocked by this one.
Evidence: 15 of 15 mutants were killed at the committed head. The CONVE-190 gate set passed (gofmt, lint, guards, full
go test ./...). Four review rounds.https://claude.ai/code/session_017ofcsFmgnoVDPxeHwuxCjg