Repository navigation
Copy a complete file into place instead of moving it when it’s outside the base path or can’t be renamed - #388
Merged
Merged
Conversation
…ot be renamed there, such as from another volume
…an moving it there
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a repair finds a complete copy of a missing file under another name, it renames that copy into place. That suits a file renamed by mistake in the same directory, but not a file that belongs elsewhere. Through libpar2, an application can load
A/set.par2and passB/file.datas a source of blocks. The repair then moves the application’s file out of B. If B is on another volume the rename fails, and the whole repair fails with it, even though every block was available. The CLI can hit the second problem when a directory inside the base path is a mount point.Now a copy that can’t be renamed is copied into place block by block, with a new
wcRenameFailedwarning. A copy outside the base path is always copied and left where it is. Copies inside the base path are still renamed as before.The CLI ignores files outside the base path, but libpar2 deliberately doesn’t follow it. Upcoming in-place repair and donor files both rely on reading blocks from files elsewhere without moving them.