Repository navigation
Fix session retry and statistics release blockers - #18
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3daea7c2e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve reading-session positions and device type in the activity ledger and serialize retry lookup before generating timestamps. Correct half-open statistics boundaries and calculate the current streak independently of the reporting period.
Adds regressions for concurrent retries, conflicting metadata, persisted/grouped metadata, midnight boundaries, point sessions and month-spanning streaks. The race regression fails against the previous locking order. Focused progress/sync/projection tests pass, as do Ruff and Mypy. Optional JSON activity fields require no additional database migration; the client mapper is updated alongside the release.
Streak calculation unions complete-day ranges and partial boundary days, so cost depends on activity count rather than the age/duration of an activity. Tests cover overlapping intervals, midnight boundaries, future clipping and a year-1-to-present interval with a bounded number of calendar operations.
Review disposition: the suggested pre-upgrade metadata fallback does not apply to this release. Published 0.0.1 (
88ab3a1) has no persisted activity ledger: its POST session route returns a generated response, and GET returns example data. The ledger and retry IDs are introduced by the still-unpublished 0.0.2 promotion. Preserve strict conflict detection for this current contract instead of adding a legacy fallback prohibited by the repository style guide.