Skip to content

feat: expose reader activity and stable content coverage - #5

Merged
Eoic merged 2 commits into
developmentfrom
feat/goals-redesign
Oct 8, 2026
Merged

Eoic merged 2 commits into
developmentfrom
feat/goals-redesign

Conversation

@Eoic

@Eoic Eoic commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Summary

Expose optional, Goals-independent activity observations from the reader: content readiness, visibility, stable EPUB coverage, exposed PDF pages/spreads, navigation cause, and end-of-document state. Existing locator callbacks, version-1 locators, custom engines, and worker parsing remain compatible. Coverage reporting preserves exact EPUB content offsets during restoration/reflow.

Testing

  • Package analysis and all 145 package tests pass, including panel visibility, custom engines, navigation, restoration, and large text.
  • Example analysis/tests/web build and worker drift check pass.
  • Browser smoke checks passed with worker, local-file, pagination, focus, settings, and theme coverage.
  • Real EPUB/PDF Android and Chromium host integration passed in client #40.

Compatibility and migration

Additive callback and snapshot fields; no Goals dependency or package version change. Target development. Merge before the client pins this revision.

Notes

The host owns clocks, lifecycle, persistence, calibration, aggregation, and explicit completion. EPUB coverage is chapter-local normalized content, not screen pagination.

Coordinated server #12 and workspace integration pin these changes without a version bump.

Workspace integration #13 pins all three component revisions and documents release order.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 13:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T13:37:33.654960Z bc617de PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc617deeaf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/src/presentation/papyrus_reader.dart Outdated
Comment thread lib/src/presentation/papyrus_reader.dart Outdated
Comment thread lib/src/domain/reader_activity.dart Outdated
Comment thread lib/src/engine/pdf/pdf_facade.dart Outdated
Comment thread lib/src/domain/reader_snapshot.dart Outdated
@Eoic
Eoic merged commit 4b2284d into development Oct 8, 2026
8 checks passed
@Eoic
Eoic deleted the feat/goals-redesign branch October 9, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants