Skip to content

Integrate rebuilt reader and preserve open book sessions - #29

Merged
Eoic merged 2 commits into
masterfrom
feat/reader-integration
Oct 3, 2026
Merged

Eoic merged 2 commits into
masterfrom
feat/reader-integration

Conversation

@Eoic

@Eoic Eoic commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Ticket

Summary

Update the Git-pinned reader to e9f91aa1a6fd6a93494e7aeba057f6f65c6e1c18, bringing rebuilt EPUB/PDF engines, responsive settings, correct reading appearance and distraction-free controls into the client.

Retain one ReaderDocument per open book so a host theme rebuild preserves the session instead of reopening and rereading its media. The media-loading screen now exposes Back. Regressions cover document identity/media reuse and popup/label contrast across real light, dark and e-ink themes, compact/wide layouts and live appearance changes.

Testing

Against the published Git dependency: enforced lockfile resolution, 23 focused reader-related client tests, formatting/analysis, four web-bootstrap tests and a web release build passed. Reader validation includes 144 tests, example checks and the Chrome worker/layout/focus/theme/resume suite.

For manual review, open EPUB and PDF books, change the app and reading themes independently, open settings menus, hide/show the controls, navigate across chapters with arrow keys, and test compact/wide layouts and PDF pagination/scroll/columns.

UI evidence

Local Chrome screenshots were visually reviewed for phone focus mode and reading settings with opposite host/reading themes; no screenshot attachments are included in this PR.

Compatibility and migration

No local path override is included. The dependency points to an immutable, already-pushed reader commit. Stored reader locator JSON remains compatible; no database migration is required.

Notes

Depends on reader PR #3. Merge reader, then client, then the workspace references. Device and cross-browser release validation remain follow-up work.

Checklist

  • The branch, commits, and pull request title follow the repository conventions.
  • The change is complete and limited to the ticket's scope.
  • Relevant tests have been added or updated.
  • Formatting, analysis, and tests pass.
  • Documentation, UI evidence, and migration notes are included where relevant.
  • No credentials, personal data, copyrighted fixtures, or unrelated generated files are included.
  • The branch is up to date with its target branch.

Copilot AI balanced review requested due to automatic review settings October 3, 2026 19:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T19:05:40.709816Z 57d670a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic merged commit 530de64 into master Oct 3, 2026
1 check passed
@Eoic
Eoic deleted the feat/reader-integration branch October 3, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants