Integrate rebuilt reader and preserve open book sessions - #29
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Summary
Update the Git-pinned reader to
e9f91aa1a6fd6a93494e7aeba057f6f65c6e1c18, bringing rebuilt EPUB/PDF engines, responsive settings, correct reading appearance and distraction-free controls into the client.Retain one
ReaderDocumentper open book so a host theme rebuild preserves the session instead of reopening and rereading its media. The media-loading screen now exposes Back. Regressions cover document identity/media reuse and popup/label contrast across real light, dark and e-ink themes, compact/wide layouts and live appearance changes.Testing
Against the published Git dependency: enforced lockfile resolution, 23 focused reader-related client tests, formatting/analysis, four web-bootstrap tests and a web release build passed. Reader validation includes 144 tests, example checks and the Chrome worker/layout/focus/theme/resume suite.
For manual review, open EPUB and PDF books, change the app and reading themes independently, open settings menus, hide/show the controls, navigate across chapters with arrow keys, and test compact/wide layouts and PDF pagination/scroll/columns.
UI evidence
Local Chrome screenshots were visually reviewed for phone focus mode and reading settings with opposite host/reading themes; no screenshot attachments are included in this PR.
Compatibility and migration
No local path override is included. The dependency points to an immutable, already-pushed reader commit. Stored reader locator JSON remains compatible; no database migration is required.
Notes
Depends on reader PR #3. Merge reader, then client, then the workspace references. Device and cross-browser release validation remain follow-up work.
Checklist