Repository navigation
Release 1.2.0 - #42
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ypriverol
force-pushed
the
release/v1.2.0
branch
from
October 7, 2026 10:01
3cf2034 to
c5b6715
Compare
- unique-samples unpacked _download_pad_files() as a list, but it returns (files, sdrf_path) since #38, so `unique-samples -a PADxxxxxx` crashed (caught by mypy on main) - get_unique_samples(exclude_controls=True) matched SampleType without normalising separators, so NEGATIVE_CONTROL / PLATE_CONTROL / SAMPLE_CONTROL were kept; it now uses control_sample_mask like filter_controls - CLI tests for unique-samples with a mocked PRIDE download
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the package version from 1.1.0 to 1.2.0 in
pyproject.toml, the only place it is defined (__version__is read from package metadata).This is a minor release: new features and fixes, no API removed. Changes since v1.1.0:
New QC
report -a(Add technology-agnostic QC plots (MPI, dynamic range, rank concordance) #37, Technology-agnostic QC (#37) with fixes, integrated into the QC layout #38)unique-samplescommandReports and PRIDE embedding
manifest.json(tabs, half- and full-width rows) and use compact layouts for embedding in an iframe (Compact split QC pages for iframe embedding (PRIDE white space) #32, Layout manifest for split QC reports (tabs, aligned two-column grid) #33, Bring layout manifest (#33) into dev #34)Fixes
After merging: create the GitHub release
v1.2.0frommain. That triggerspublish.yml, which uploads to PyPI.Also in this PR (found by CI on
main):unique-samples -a PADxxxxxxcrashed, because_download_pad_filesreturns(files, sdrf)since Technology-agnostic QC (#37) with fixes, integrated into the QC layout #38. Fixed.unique-samples --exclude-controlskeptNEGATIVE_CONTROL,PLATE_CONTROLandSAMPLE_CONTROLsamples. It now uses the same control matching asfilter_controls.tests/test_cli.pycovers both.Checked with CI's versions: mypy clean, ruff clean, 166 tests passed.