Skip to content

🐞 Preserve rounded PDF page corners in narrow viewports #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JFWooten4 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −11
Open

🐞 Preserve rounded PDF page corners in narrow viewports #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/viewer/viewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,13 +1086,9 @@ input {
}

@media (max-width: 720px) {
/* Preserve the page outline and rounded corners in narrow split views. */
.viewer {
padding-inline: 0;
}

.page {
width: 100%;
border-radius: 0;
padding-inline: 8px;
}

.toolbar {
Expand Down
11 changes: 6 additions & 5 deletions tests/narrow-viewer-layout.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ const viewerStyles = readFileSync(new URL("../src/viewer/viewer.css", import.met
const toolbarStyles = readFileSync(new URL("../src/viewer/navigation/toolbar-layout.css", import.meta.url), "utf8");
const minimapStyles = readFileSync(new URL("../src/viewer/navigation/minimap.css", import.meta.url), "utf8");

test("narrow PDF pages reach the horizontal viewport edges", () => {
assert.match(
viewerStyles,
/@media \(max-width: 720px\)[\s\S]*?\.viewer\s*\{[\s\S]*?padding-inline:\s*0;[\s\S]*?\}[\s\S]*?\.page\s*\{[\s\S]*?width:\s*100%;[\s\S]*?border-radius:\s*0;[\s\S]*?\}/,
);
test("narrow PDF pages preserve rounded, outlined corners with side clearance", () => {
assert.match(viewerStyles, /\.page\s*\{[^}]*border-radius:\s*8px;[^}]*box-shadow:\s*0 0 0 1px var\(--page-border\);/);
assert.match(viewerStyles, /\.viewer\s*\{[^}]*padding:\s*calc\(52px \+ var\(--page-top-gap\)\) 16px/);
const narrowRules = viewerStyles.split("@media (max-width: 720px) {").at(-1).split("@media (max-width: 560px) {")[0];
assert.match(narrowRules, /\.viewer\s*\{\s*padding-inline:\s*8px;/);
assert.doesNotMatch(narrowRules, /\.page\s*\{/);
});

test("rendered page surfaces inherit the rounded page corners", () => {
Expand Down
Loading