Skip to content

🐞 Fix compact PDF search and Sweetie Bot alignment #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JFWooten4 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🐞 Fix compact PDF search and Sweetie Bot alignment #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50c52de
🐞 Align compact PDF search bar with Sweetie Bot
JFWooten4 Oct 22, 2026
629a8cd
🧪 Guard Sweetie Bot spacing in the compact PDF toolbar
JFWooten4 Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/viewer/navigation/toolbar-layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@
.search-tools {
top: 56px;
left: 8px;
width: calc(100% - 88px);
/* Sweetie Bot: 8px outer inset + 30px button + 8px gap. */
right: 46px;
width: auto;
transform: none;
}

Expand Down
32 changes: 32 additions & 0 deletions tests/printed-page-jump.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,3 +151,35 @@ test("clicking total page count requests the final physical page", () => {
handlers.click();
assert.ok(selected, "the current page is still selectable");
});

test("compact two-row search ends beside Sweetie Bot instead of leaving a large gap", () => {
const html = readFileSync(new URL("../src/viewer.html", import.meta.url), "utf8");
const layout = readFileSync(new URL("../src/viewer/navigation/toolbar-layout.css", import.meta.url), "utf8");
const viewerCss = readFileSync(new URL("../src/viewer/viewer.css", import.meta.url), "utf8");
const toolbarScript = readFileSync(new URL("../src/viewer/navigation/toolbar-layout.js", import.meta.url), "utf8");

assert.match(toolbarScript, /TOOLBAR_ROW_BREAKPOINT\s*=\s*900/);
assert.match(html, /class="search-tools"[\s\S]*?id="search-input"[\s\S]*?class="search-actions"[\s\S]*?id="summarize-chatgpt"/);

const twoRow = layout.match(/:where\(:root\.toolbar-two-rows\)\s*\{([\s\S]*?)\n\}/)?.[1];
assert.ok(twoRow, "the narrow layout must retain its second toolbar row");
const search = twoRow.match(/ \.search-tools\s*\{([^}]*)\}/)?.[1];
const actions = twoRow.match(/ \.search-actions\s*\{([^}]*)\}/)?.[1];
assert.ok(search && actions);
assert.match(search, /top:\s*56px;/);
assert.match(search, /left:\s*8px;/);
assert.match(search, /width:\s*auto;/);
assert.match(actions, /top:\s*56px;/);
const searchRightInset = Number(search.match(/right:\s*(\d+)px;/)?.[1]);
const buttonRightInset = Number(actions.match(/right:\s*(\d+)px;/)?.[1]);
const markButton = viewerCss.match(/\.mark-button\s*\{([^}]*)\}/)?.[1];
const buttonWidth = Number(markButton?.match(/width:\s*(\d+)px;/)?.[1]);
assert.equal(buttonWidth, 30, "Sweetie Bot uses the shared mark-button width");

for (const width of [320, 500, 720, 900]) {
const searchRightEdge = width - searchRightInset;
const sweetieLeftEdge = width - buttonRightInset - buttonWidth;
assert.equal(sweetieLeftEdge - searchRightEdge, 8, `search/Sweetie spacing at ${width}px`);
assert.ok(searchRightEdge > 8 + buttonWidth + 8 + 40, "search field remains usable");
}
});
Loading