Skip to content

Fix outdated KDoc - #55

Merged
jrosendahl-opt merged 1 commit into
masterfrom
fix/kdoc
Nov 4, 2026
Merged

jrosendahl-opt merged 1 commit into
masterfrom
fix/kdoc

Conversation

@jrosendahl-opt

@jrosendahl-opt jrosendahl-opt commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Why

Several KDoc comments described the SDK as it used to be: an "Optable Sandbox", a WebView-based user agent, a method name that no longer exists, "encrypted" identifiers, and wrong return or parameter types. These show up in IDE hover docs for every integrator.

OptableSDK's docs still called the DCN an "Optable Sandbox" and said the
context is needed to build a WebView for the user agent; list what the
context is actually used for instead. The tryIdentifyFromUrl doc named it
tryIdentifyFromURI, and the targeting docs said identifiers are
"encrypted" rather than hashed.

prefixedIdFromUrl returns null, not an empty string, when no oeid is
found, and OptableConsents.gdprSubject is a Boolean, not an integer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jrosendahl-opt
jrosendahl-opt requested review from a team as code owners November 3, 2026 20:22
@jrosendahl-opt
jrosendahl-opt merged commit f1fc601 into master Nov 4, 2026
3 checks passed
@jrosendahl-opt
jrosendahl-opt deleted the fix/kdoc branch November 4, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants