Repository navigation
Fix the broken README examples - #53
Merged
Merged
Conversation
Several README examples didn't compile against the current SDK: they used the removed OptableIdentifiers class, a non-existent `audiences` field, `req` instead of `reg` in OptableConsents, the wrong result type for profile() in Java, and missing semicolons. The Java examples also relied on Guava's Lists.newArrayList. Also describe how the default user agent is obtained (WebSettings.getDefaultUserAgent), drop the "fifth parameter" wording for customUserAgent, say email and phone are hashed rather than encrypted, and remove null checks on gamTargetingKeywords, which is never null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mosherBT
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several README examples didn't compile against the current SDK, and some prose described behaviour the SDK no longer has. Developers copying them hit errors straight away.
What Changed
OptableIdentifiersclass; they now useOptableIdentifier(listOf(OptableIdentifier.Email(…))/Arrays.asList(new OptableIdentifier.Email(…)))..audiences/getAudiences(), which don't exist; they now readgamTargetingKeywords.gamTargetingKeywordsare removed: it's a non-nullMap.profileexample matchedOptableResult.Error<Unit>;profilereturnsOptableResult<OptableTargeting>.Lists.newArrayList; they now useArrays.asList.req = "gdpr"; the parameter isreg.WebSettings.getDefaultUserAgent(), not from aWebView'ssettings.userAgentString.customUserAgentwas called the "fifth parameter"; it's the eighth, and the examples pass it by name.