Stop the chevron pushing menu labels into an ellipsis (develop) - #239
Merged
Merged
Conversation
…r collapses into an ellipsis Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to T51ENG-2081
Proposed changes
Why are these changes being made?
Top-level menu links are
text-overflow: ellipsis. The chevron was an inline pseudo-element, so it counted toward the text width and pushed longer labels over their box: Firefox rendered the label as "News & Events..." with the chevron beside it. Taking the chevron out of flow lets the label measure on its own.The earlier fix assumed the mask was repainting during the rotation. It was not: the ellipsis and the chevron appeared together, which is what identified the real cause.
Testing instructions
🤖 Generated with Claude Code