Fix the dismissed state stranding mega menu panels (develop) - #237
Merged
Conversation
…e the page dimmed with no menu Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011rCHPCdbV5C5dDJjEmMDuy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to T51ENG-2081
Proposed changes
nav_menu_item_attributescallback.Why are these changes being made?
Pressing Escape marked every mega menu item as dismissed, and only moving the pointer off an item cleared it. Hovering a different item afterwards, or reopening the same one without moving the mouse, left the page dimmed and the header opaque with no panel visible. Keyboard users had no way to clear it at all.
The walker's filter callback declared typed parameters. That filter is public and live for the whole of the walk, so another walker re-applying it with fewer arguments, or with
$argsas an array, would throw and take the header down site-wide. The matching callback intemplate-functions.phpwas already relaxed for this reason.Testing instructions
🤖 Generated with Claude Code