Repository navigation
feat: derive Property page title from name in get_title - #5
Merged
Merged
Conversation
- return entity.name for Property instances without meta title - apply in opensemantic and opensemantic.v1 - add opensemantic.core to testing extra - add tests for both model versions
Merged
4 tasks done
LukasGold
commented
Nov 13, 2026
LukasGold
left a comment
LukasGold
left a comment
Contributor
Author
There was a problem hiding this comment.
Review: Agentic code changes look fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Changes
get_titleinsrc/opensemantic/_model.pyandsrc/opensemantic/v1/_model.pynow returns, in this order:meta.wiki_page.title, if set (unchanged)entity.name, if the entity is aProperty(including subclasses) andnameis not emptyOSW<uuid hex>(unchanged)get_full_titleandget_irifollow, so a property givesProperty:<name>.get_namespaceis unchanged.opensemantic.coreis added to thetestingextra insetup.cfg, because the new tests import it.tests/property_title_test.pyforopensemantic.coreandopensemantic.core.v1.Rationale
The wiki form editor names a property page after
jsondata.namewithout transformation (PageBot.js L951-L970). Python code gaveProperty:OSW<uuid>, which differs from the page the wiki creates and from theProperty:<Name>targets in schema@contextmappings.Known limitation
name, the derived title changes. This is out of scope here.