Add player benchmarks: play handshake and 500/1000 viewers - #33
Conversation
The benchmark page gets a connect + play section and a load section with join latency, server CPU and memory at 500 and 1000 viewers; the full results gain both tables. All numbers are refreshed from the new sweeps. Bar charts now badge whichever server leads, since librtmp2-server does not lead every chart (1-viewer and 500-viewer joins, CPU, memory). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017zwRjF57hJ56nbsK7yApc6
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe benchmark data now includes playback handshakes and load measurements at 500 and 1,000 viewers. The page displays playback and load charts and tables, updates ranking badges, and revises English and German benchmark descriptions and responsive styling. ChangesBenchmark results and presentation
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue remains; the benchmark presentation is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |



Before: /benchmarks/ only covered the publisher handshake and viewer joins at up to 100 viewers. It also said librtmp2-server had the lowest latency in every test.
After: EN and DE get two new sections, and the full results table gains both of them:
Other changes:
The bar charts now badge whichever server actually leads. The badge says "Leanest" / "Sparsamster" on the CPU and memory charts, and every other row shows its factor behind the leader. librtmp2-server does not lead every chart:
How:
OPENRTMP_BENCH_PLAY_HANDSHAKEandOPENRTMP_BENCH_LOADare new inincludes/benchmarks-data.php, copied from librtmp2-server's BENCHMARKS.md (OpenRTMP/librtmp2-server#254). The shared template renders both new sections.🤖 Generated with Claude Code
https://claude.ai/code/session_017zwRjF57hJ56nbsK7yApc6
Generated by Claude Code
Summary by CodeRabbit