Report a failed verification as two .mat files - #348
Merged
Conversation
Member
Author
|
This is a draft PR because it requires a newer OMC to perform the reference comparison |
A failed comparison used to produce a CSV and a dygraph HTML page per
differing variable, plus an index page: `diffSimulationResults` wrote
the CSVs itself, testmodel.py the HTML, and every double became text on
the way. It now writes two files, the result and the reference reduced
to the differing variables with `filterSimulationResults`, and the
report links them to the OMPlot page of the OpenModelica playground,
which runs the same tube comparison in the browser and plots every
variable on demand:
https://playground.openmodelica.org/latest/omplot/?result=…&reference=…
The page needs absolute URLs, so library.html.tpl resolves the two
relative paths at load time; without JavaScript the link is the result
file itself. `diffSimulationResults` is called with an empty prefix,
which (since the matching omc change) writes no per-variable CSV.
Filtering a CSV reference needs an omc with that change as well; an
older one logs the failure to the .err and the report has no
reference file for that model.
The files server has to allow cross-origin reads (Access-Control-
Allow-Origin) for the page to fetch them.
The docker images were updated to pull in the nightly omc since it
is needed for the small API changes to `filterSimulationResults`.
Assisted-by: Claude Fable 5.1
sjoelund
force-pushed
the
new-reference-comparison
branch
from
September 9, 2026 05:51
b190901 to
ce78849
Compare
sjoelund
marked this pull request as ready for review
September 9, 2026 05:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed comparison used to produce a CSV and a dygraph HTML page per differing variable, plus an index page:
diffSimulationResultswrote the CSVs itself, testmodel.py the HTML, and every double became text on the way. It now writes two files, the result and the reference reduced to the differing variables withfilterSimulationResults, and the report links them to the OMPlot page of the OpenModelica playground, which runs the same tube comparison in the browser and plots every variable on demand:The page needs absolute URLs, so library.html.tpl resolves the two relative paths at load time; without JavaScript the link is the result file itself.
diffSimulationResultsis called with an empty prefix, which (since the matching omc change) writes no per-variable CSV. Filtering a CSV reference needs an omc with that change as well; an older one logs the failure to the .err and the report has no reference file for that model.The files server has to allow cross-origin reads (Access-Control- Allow-Origin) for the page to fetch them.
Assisted-by: Claude Fable 5.1