Repository navigation
feat: align native camera horizontal field of view - #9
Merged
Merged
Conversation
kleinlau17
force-pushed
the
feat/camera-horizontal-fov
branch
from
October 24, 2026 13:35
fb46059 to
f678cca
Compare
kleinlau17
commented
Oct 24, 2026
kleinlau17
left a comment
Contributor
Author
There was a problem hiding this comment.
本轮代理代码审查完成,未发现阻断合并的问题。核对了可选 horizontalFov 的校验与旧配置兼容、MuJoCo 全画幅视锥半宽及裁剪顺序、共享 golden、GL 子进程隔离,以及 scene/meta 初始消息与登记相对广播的原子性。首帧回归测试在旧实现可稳定复现,修复后通过。
由于 main 新合入 #8,本 PR 已 rebase 到 3173fc6;唯一冲突是 docs/component-reference.md 末尾两段独立文档,均保留。range-diff 确认两项 CI 修复补丁不变。更新后本地完整测试 796 passed、1 skipped、2 deselected、58 subtests passed,ruff 和 diff 检查通过。等待当前 head 的 CI 完成后,按用户本轮明确授权通过 GitHub PR 合并;此记录是代理审查,不冒充仓库负责人审批。
kleinlau17
commented
Oct 24, 2026
kleinlau17
left a comment
Contributor
Author
There was a problem hiding this comment.
补充审查当前 head:新增的一行仅为 wheel 验收命令显式指定 --native,修复验收脚本使用旧默认模式的假设;无新增运行时变更,无阻断发现。已用普通安装 wheel 与合并版 BotLab runtime 完成20原生回合、10编辑器/10发布页、跨域iframe、真实原生viewer和10次首帧连接检查,结果通过。等待本 head CI 四组全部通过后,按用户明确授权合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为原生相机增加可选
horizontalFov,与 BotLab 浏览器独立横纵视野标定保持一致。省略/null 时仍按纵向fov和完整传感器宽高推导横向视野。配套 BotLab #58 已合入 dev。--native。审查与合并
按用户明确授权,经代理代码审查和检查后已 squash 合入 main:
9a6943dbde16eb61084524891ae11a65b38de84a。代理审查记录不冒充人工负责人审批,仓库负责人为项总。main 新合入 #8 后,本分支更新到
3173fc6,唯一冲突为文档末尾追加段落,保留双方内容。最终 PR head1f5c090的 CI run 40099177648 四组 Python 3.10–3.13 全部通过:lint、测试、原生处理器 golden、非 editable source wheel 契约检查均通过。最新隔离验收(2026-10-24)
独立工程
supermimic-project-horizontal-fov-merged使用普通 wheel、独立 runtime 缓存。固定 SDK 合并提交9a6943d与 BotLab dev 已合入提交794ccea。合并源码树与验收提交一致;合并后重新构建 wheel,与已验收安装包逐字节一致。本地完整 SDK 套件796 passed、1 skipped、2 deselected、58 subtests passed;安装包的显示/相机31项通过(实际GL无跳过);独立工程回合测试7项通过。BotLab editor/viewer构建通过。
产物身份
两个产物仍标记0.3.0,以以下哈希区分本轮本地构建,并非新发布版本:
2ff236d4f66f6d044e8c050e7563dede04f7c8101bb828dedf0eed407ebb34a9ed942b8801d7545aef6e619beef461971f31f8f68c5d2ba299c242822bd9f96ereports/、output/playwright/;汇总为reports/merged-validation.md与.migration/versions.json。验证边界与失败原因
原生逐控制步检查,浏览器为显示时钟采样;不是官方成功率,也不代表与上游完整环境逐步等价。相同输入下独立观测组装/融合策略最大误差5.7220459e-6。浏览器动作结束仍按原流程暂停,没有扩展回合管理。编辑器只有既有/api/auth/me 404。
首次CI失败是无显示环境下MuJoCo Renderer原生abort;隔离后发现另一处scene描述发送与注册之间的真实首帧竞争,均已修复。本轮完整wheel验收还修复了测试脚本误用默认浏览器模式的问题。
不修改策略、执行器、运动数据、深度后端或噪声;本任务不上传PyPI/GitHub Release,不推进FAT/生产部署。