Repository navigation
fix: align motion preview in SDK and editor release plans - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与修复
编辑器的
Motion.sample已输出显式 preview 字段,但 Python SDK 编译的发布包缺少该字段,会走 runtime 的旧计划 Ghost 预览回退路径,造成编辑器与发布包行为不同。将
_resources.py与 BotLab canonical 模块逐字节同步:Motion.sample(..., preview=False)默认显式关闭该采样节点的预览,允许preview=True,并拒绝非布尔值。增加从项目加载、编译到 release 打包的回归测试,覆盖默认值、显式 false/true 和类型校验。跨仓关系
BotLab 配套 PR:https://github.com/OpenLegged/BotLab/pull/50。
canonical 来源为 BotLab
cf98f06dbc15c722189c2739772028054f9659c5的src/domain/python/botlab/_resources.py;逐字节比较通过。本次不带入其他 SDK 镜像差异。平台先提供 Ghost 相机隔离并保留旧计划兼容,再配套 SDK 统一预览字段;SDK 字段同步本身不能替代 runtime 的隔离修复。未扩展回合管理、原生 runner 或策略专用 API,未修改包版本、发布 wheel 或替换线上 runtime。
本地检查
基于
ea7b5519d484abcd58f901f9d308b2933c70a0bb。.venv/bin/ruff check ..venv/bin/python -m pytest --basetemp=tmp/pytestcmp src/botlab/sdk/_resources.py ../BotLab/src/domain/python/botlab/_resources.pyuv build --wheel --out-dir <isolated-project>/.migration/wheels独立项目实际执行了
tools/evaluate_all.py --mode eval --episodes 2、tools/evaluate_all.py --mode play --episodes 1、tools/build_all.py、tools/build_legacy_sites.py、tools/check_browsers.py --surface editor/site/legacy(三个入口分别运行)和tools/verify_preview_plans.py。这些为独立项目验收脚本,不是 SDK 自带命令。BotLab 配套检查包括 34 项相关单测、lint/typecheck/dev/viewer 构建、6 项嵌入 E2E 和 2 项 macOS GPU 测试;默认 Vulkan 参数在 macOS 的失败及复测条件详见配套 PR。配套验证(2026-10-24,本地隔离环境)
使用 SuperMimic 独立项目、独立 venv 和 runtime 缓存验证;控制代码、策略、preset、阈值及回合管理保持原样。
浏览器跟踪检查基于显示时钟、qpos 快照和离线 FK,是采样帧检查,不是每控制步完整 Eval,也不是上游统计成功率。标准入口动作末尾仍需手动暂停;没有扩展回合管理。新旧发布页无资源失败、console error 或未捕获异常;本地编辑器仅有无账号服务的 /api/auth/me 404。
验证产物仍标为本地 0.3.0 候选,未发布,按 SHA-256 识别:
92d775ecbbee40c1fe6f3fb9417f853f9e6983e7528ef49c434140bd826346076a0aa395f3866c74ea3c68476298e7f83551ea4485c22e0dba98786f03b73744be6b0e8dcde26fd1732c9dba9cc3db563e77e8e0091d5cd4473904054bac2597完整执行记录、截图和报告保留在本地
supermimic-project-ghost-fix/reports/ghost-fix-validation.md及同目录证据文件;大体积策略和构建产物未纳入源码 PR。审核
目标分支
main(SDK 仓不走业务仓 FAT 分支)。请项总审核实际改动和上述本地 CI 记录。已获用户授权:检查 CI、修复失败项后通过此 PR 合并;不发布 wheel。合并前远端 CI 结果
GitHub Actions run 40081386196,head
70d9ec5a2d4c366075659e3849b8c55b1a74aae2:Python 3.10 / 3.11 / 3.12 / 3.13 四项均 SUCCESS,包含 lint、pytest、golden processor parity、非 editable source wheel contract。CI 使用不含 UI 的源码 wheel 检查,不能替代发布 wheel 的完整验收;本地带 UI 候选的验证见上文。无失败 CI 任务,无额外代码修复。BotLab 配套 PR #50 已合入 dev,提交
bd8ab6ab635fd8be6b8145db7dc74814b4fde0a1;不表示平台已部署。