Repository navigation
G2P-5803 Refactor registry adapters and build process for pbms-connectors - #1
Merged
venky-ganapathy-openG2P merged 6 commits intoOct 30, 2026
Conversation
BREAKING CHANGE: sql_query column is removed from eligibility, entitlement and priority rule definitions (core models and odoo module), along with the _build_sql_query pipeline and the agent's query UI fields. Rules now carry pbms_domain only, which the registry adapters evaluate.
Registry adapters and odoo registry/theme addons now live in pbms-connectors, whose images extend these bases. Drop their COPY and pip lines here and remove extensions from the lint matrix. BREAKING CHANGE: docker builds no longer bake registry adapters; deploy the pbms-connectors images/chart instead.
Workers and staff API no longer open sessions on the registry database. The registry adapter interface (now in pbms-connectors) owns that access and takes only the bg-task session. Eligibility, disbursement and multiplier math use adapter iter_*/multiplier helpers instead of rule SQL; query_helper is gone. BREAKING CHANGE: registry-interface call signatures (search, compute, entitlement) changed; adapters must ship the matching version.
One openg2p-pbms-celery-base runs either app: run_celery.py picks the app from CELERY_APP and the args from CELERY_OPTS, both set per deployment by the chart. Env examples updated for the merged image and the registry adapter keys. BREAKING CHANGE: openg2p-pbms-bg-task-celery-workers and openg2p-pbms-bg-task-celery-beat-producers images are replaced by openg2p-pbms-celery-base + CELERY_APP.
The platform chart keeps the templates and points at the base images; the user-facing openg2p-pbms chart (pbms-connectors) depends on it and sets the connector images. Values gain the registry connector/partner-API settings. BREAKING CHANGE: install openg2p-pbms from pbms-connectors instead of deploying this chart directly.
Retargets the build: odoo and staff api build as -base images, bene api renames to openg2p-pbms-beneficiary-api, and the single celery base replaces the separate beat and worker publishes. Chart path moves to openg2p-pbms-platform. README reflects the layout.
tahzeer
marked this pull request as draft
October 29, 2026 12:07
tahzeer
marked this pull request as ready for review
October 30, 2026 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G2P-5803